Commit a306a2c
authored
# Description
When using CLI, i noticed random calls to `/version` when using it which
was confusing (i'd only expect it to be called if I'm trying to see the
version). Since `/version` is not a "public path" (not in our list of
paths to avoid doing AuthN checks), there are also 3 lines of
"unauthenticated -> /v0/version" fails each CLI call.
We could add `/version` as a public path if we don't believe having
build/run info public is an issue, but at the core level if we're
checking for a response, we should be hitting between `/ping` or
`/health`. I chose `/ping` since this is doing a response check not
actual health checks per daemon-call.
**Changes**
- Use `/ping` for response checks
- Check for HTTP `200` specifically for OK-ness. Huma defaults to a 200
code on responses with a body (which the /ping endpoint provides.)
# Change Type
```
/kind cleanup
```
# Changelog
```release-note
NONE
```
# Additional Notes
Signed-off-by: Fabian Gonzalez <fabian.gonzalez@solo.io>
1 parent 89dc215 commit a306a2c
1 file changed
+3
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
17 | | - | |
| 17 | + | |
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
| 45 | + | |
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| |||
0 commit comments