Skip to content

Commit 7cdf95b

Browse files
committed
Apply missing presto_protocol changes from prior commits
1 parent 212d4ac commit 7cdf95b

File tree

7 files changed

+189
-245
lines changed

7 files changed

+189
-245
lines changed

presto-main/src/main/java/com/facebook/presto/execution/TaskInfo.java

+14-36
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@
3535
import static com.facebook.presto.execution.TaskStatus.initialTaskStatus;
3636
import static com.facebook.presto.execution.buffer.BufferState.OPEN;
3737
import static com.facebook.presto.metadata.MetadataUpdates.DEFAULT_METADATA_UPDATES;
38-
import static com.facebook.presto.util.DateTimeUtils.toTimeStampInMillis;
3938
import static com.google.common.base.MoreObjects.toStringHelper;
4039
import static com.google.common.base.Preconditions.checkArgument;
4140
import static java.lang.System.currentTimeMillis;
@@ -56,51 +55,30 @@ public class TaskInfo
5655
private final MetadataUpdates metadataUpdates;
5756
private final String nodeId;
5857

59-
public TaskInfo(TaskId taskId,
60-
TaskStatus taskStatus,
61-
long lastHeartbeatInMillis,
62-
OutputBufferInfo outputBuffers,
63-
Set<PlanNodeId> noMoreSplits,
64-
TaskStats stats,
65-
boolean needsPlan,
66-
MetadataUpdates metadataUpdates,
67-
String nodeId)
68-
{
69-
this.taskId = requireNonNull(taskId, "taskId is null");
70-
this.taskStatus = requireNonNull(taskStatus, "taskStatus is null");
71-
checkArgument(lastHeartbeatInMillis >= 0, "lastHeartbeat is negative");
72-
this.lastHeartbeatInMillis = lastHeartbeatInMillis;
73-
this.outputBuffers = requireNonNull(outputBuffers, "outputBuffers is null");
74-
this.noMoreSplits = requireNonNull(noMoreSplits, "noMoreSplits is null");
75-
this.stats = requireNonNull(stats, "stats is null");
76-
77-
this.needsPlan = needsPlan;
78-
this.metadataUpdates = metadataUpdates;
79-
this.nodeId = requireNonNull(nodeId, "nodeId is null");
80-
}
81-
8258
@JsonCreator
8359
@ThriftConstructor
8460
public TaskInfo(
8561
@JsonProperty("taskId") TaskId taskId,
8662
@JsonProperty("taskStatus") TaskStatus taskStatus,
87-
@JsonProperty("lastHeartbeat") DateTime lastHeartbeat,
63+
@JsonProperty("lastHeartbeatInMillis") long lastHeartbeatInMillis,
8864
@JsonProperty("outputBuffers") OutputBufferInfo outputBuffers,
8965
@JsonProperty("noMoreSplits") Set<PlanNodeId> noMoreSplits,
9066
@JsonProperty("stats") TaskStats stats,
9167
@JsonProperty("needsPlan") boolean needsPlan,
9268
@JsonProperty("metadataUpdates") MetadataUpdates metadataUpdates,
9369
@JsonProperty("nodeId") String nodeId)
9470
{
95-
this(taskId,
96-
taskStatus,
97-
toTimeStampInMillis(lastHeartbeat),
98-
outputBuffers,
99-
noMoreSplits,
100-
stats,
101-
needsPlan,
102-
metadataUpdates,
103-
nodeId);
71+
this.taskId = requireNonNull(taskId, "taskId is null");
72+
this.taskStatus = requireNonNull(taskStatus, "taskStatus is null");
73+
checkArgument(lastHeartbeatInMillis >= 0, "lastHeartbeat is negative");
74+
this.lastHeartbeatInMillis = lastHeartbeatInMillis;
75+
this.outputBuffers = requireNonNull(outputBuffers, "outputBuffers is null");
76+
this.noMoreSplits = requireNonNull(noMoreSplits, "noMoreSplits is null");
77+
this.stats = requireNonNull(stats, "stats is null");
78+
79+
this.needsPlan = needsPlan;
80+
this.metadataUpdates = metadataUpdates;
81+
this.nodeId = requireNonNull(nodeId, "nodeId is null");
10482
}
10583

10684
@JsonProperty
@@ -117,13 +95,13 @@ public TaskStatus getTaskStatus()
11795
return taskStatus;
11896
}
11997

120-
@JsonProperty
121-
@ThriftField(3)
12298
public DateTime getLastHeartbeat()
12399
{
124100
return new DateTime(lastHeartbeatInMillis);
125101
}
126102

103+
@JsonProperty
104+
@ThriftField(3)
127105
public long getLastHeartbeatInMillis()
128106
{
129107
return lastHeartbeatInMillis;

0 commit comments

Comments
 (0)