[project] add strict null checks to improve logic (#234)

Co-authored-by: Rohan Bansal <[email protected]>

Author: Alchez

aform/src/directives/mask.ts

@@ -43,12 +43,12 @@ function getMask(binding: DirectiveBinding<string>) {
 		if (maskFn) {
 			// TODO: (state) replace with state management;
 			// pass the entire form/table data to the function
-			const locale = binding.instance['locale']
+			const locale = binding.instance?.['locale']
 			mask = maskFn(locale)
 		}
 	} else {
 		// TODO: (state) handle using state management
-		const schema = binding.instance['schema'] as FormSchema
+		const schema = binding.instance?.['schema'] as FormSchema
 		const fieldType: string | undefined = schema?.fieldtype?.toLowerCase()
 		if (fieldType && NAMED_MASKS[fieldType]) {
 			mask = NAMED_MASKS[fieldType]
@@ -127,7 +127,7 @@ export function useStringMask(el: HTMLInputElement, binding: DirectiveBinding<st
 		// most likely fixed with state management;
 		// a better way could be to emit back to instance;
 
-		if (binding.instance['maskFilled']) {
+		if (binding.instance?.['maskFilled']) {
 			binding.instance['maskFilled'] = !replacement.includes(maskToken)
 		}
 

aform/tests/datepicker.spec.ts

@@ -48,7 +48,13 @@ describe('datepicker component', () => {
 
 		const $prevMonthBtn = wrapper.find('#previous-month-btn')
 		await $prevMonthBtn.trigger('click')
-		expect(wrapper.vm.currentMonth).toBe(new Date().getMonth() - 1)
+
+		const currentMonth = new Date().getMonth()
+		if (currentMonth === 0) {
+			expect(wrapper.vm.currentMonth).toBe(11)
+		} else {
+			expect(wrapper.vm.currentMonth).toBe(currentMonth - 1)
+		}
 	})
 
 	it('select previous year', async () => {

atable/src/components/ACell.vue

@@ -90,9 +90,9 @@ const showModal = () => {
 			state.modal.visible = true
 			state.modal.colIndex = colIndex
 			state.modal.rowIndex = rowIndex
-			state.modal.parent = cellRef.value
-			state.modal.top = cellRef.value.offsetTop + cellRef.value.offsetHeight
-			state.modal.left = cellRef.value.offsetLeft
+			state.modal.parent = cellRef.value!
+			state.modal.top = cellRef.value!.offsetTop + cellRef.value!.offsetHeight
+			state.modal.left = cellRef.value!.offsetLeft
 			state.modal.width = width.value
 			state.modal.height = height.value
 
@@ -146,7 +146,7 @@ if (addNavigation) {
 
 const onFocus = () => {
 	if (cellRef.value) {
-		currentData.value = cellRef.value.textContent
+		currentData.value = cellRef.value.textContent!
 	}
 }
 
@@ -156,14 +156,14 @@ const updateCellData = (payload: Event) => {
 		return
 	}
 
-	emit('cellInput', colIndex, rowIndex, target.textContent, currentData.value)
-	currentData.value = target.textContent
+	emit('cellInput', colIndex, rowIndex, target.textContent!, currentData.value)
+	currentData.value = target.textContent!
 
 	// only apply changes if the cell value has changed after being mounted
 	if (column.format) {
 		cellModified.value = target.textContent !== store.getFormattedValue(colIndex, rowIndex, originalData)
 		// TODO: need to setup reverse format function?
-		store.setCellText(colIndex, rowIndex, target.textContent)
+		store.setCellText(colIndex, rowIndex, target.textContent!)
 	} else {
 		cellModified.value = target.textContent !== originalData
 		store.setCellData(colIndex, rowIndex, target.textContent)

atable/src/components/ARow.vue

@@ -26,7 +26,7 @@
 
 <script setup lang="ts">
 import { type KeypressHandlers, useKeyboardNav, defaultKeypressHandlers } from '@stonecrop/utilities'
-import { useTemplateRef } from 'vue'
+import { computed, useTemplateRef } from 'vue'
 
 import { createTableStore } from '../stores/table'
 
@@ -43,8 +43,9 @@ const {
 }>()
 
 const rowRef = useTemplateRef<HTMLTableRowElement>('rowEl')
-const isRowVisible = store.isRowVisible(rowIndex)
-const rowExpandSymbol = store.getRowExpandSymbol(rowIndex)
+
+const isRowVisible = computed(() => store.isRowVisible(rowIndex))
+const rowExpandSymbol = computed(() => store.getRowExpandSymbol(rowIndex))
 
 if (addNavigation) {
 	let handlers = defaultKeypressHandlers

atable/src/stores/table.ts

@@ -56,7 +56,7 @@ export const createTableStore = (initData: {
 				defaultDisplay[rowIndex] = {
 					childrenOpen: false,
 					expanded: false,
-					indent: row.indent || null,
+					indent: row.indent || 0,
 					isParent: parents.has(rowIndex),
 					isRoot: row.parent === null || row.parent === undefined,
 					rowModified: false,
@@ -85,7 +85,9 @@ export const createTableStore = (initData: {
 			return `${indent}ch`
 		})
 
-		const zeroColumn = computed(() => ['list', 'tree', 'list-expansion'].includes(config.value.view))
+		const zeroColumn = computed(() =>
+			config.value.view ? ['list', 'tree', 'list-expansion'].includes(config.value.view) : false
+		)
 
 		// actions
 		const getCellData = <T = any>(colIndex: number, rowIndex: number): T => table.value[`${colIndex}:${rowIndex}`]
@@ -113,7 +115,7 @@ export const createTableStore = (initData: {
 		const getHeaderCellStyle = (column: TableColumn): CSSProperties => ({
 			minWidth: column.width || '40ch',
 			textAlign: column.align || 'center',
-			width: config.value.fullWidth ? 'auto' : null,
+			width: config.value.fullWidth ? 'auto' : undefined,
 		})
 
 		const isRowVisible = (rowIndex: number) => {

beam/src/composables/mqtt.ts

@@ -9,8 +9,8 @@ import { IMqttStream } from '../types'
  * @returns MQTT stream messages
  * @beta
  */
-export const useMqttStream = (options?: IMqttStream) => {
-	const client = ref<MqttClient>(null)
+export const useMqttStream = (options: IMqttStream) => {
+	const client = ref<MqttClient>()
 	const messages = ref<Record<string, string[]>>({})
 
 	onMounted(() => {
@@ -38,7 +38,7 @@ export const useMqttStream = (options?: IMqttStream) => {
 	})
 
 	onUnmounted(() => {
-		client.value.end()
+		client.value?.end()
 	})
 
 	return { messages }

common/changes/@stonecrop/aform/fix-null-checks_2025-01-09-11-04.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@stonecrop/aform",
+      "comment": "add strict null checks to improve logic",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@stonecrop/aform"
+}

common/changes/@stonecrop/atable/fix-null-checks_2025-01-09-11-04.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@stonecrop/atable",
+      "comment": "add strict null checks to improve logic",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@stonecrop/atable"
+}

common/changes/@stonecrop/beam/fix-null-checks_2025-01-09-11-04.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@stonecrop/beam",
+      "comment": "add strict null checks to improve logic",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@stonecrop/beam"
+}

common/changes/@stonecrop/desktop/fix-null-checks_2025-01-09-11-04.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@stonecrop/desktop",
+      "comment": "add strict null checks to improve logic",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@stonecrop/desktop"
+}

common/changes/@stonecrop/stonecrop/fix-null-checks_2025-01-09-11-04.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@stonecrop/stonecrop",
+      "comment": "add strict null checks to improve logic",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@stonecrop/stonecrop"
+}

common/changes/@stonecrop/utilities/fix-null-checks_2025-01-09-11-04.json

@@ -0,0 +1,10 @@
+{
+  "changes": [
+    {
+      "packageName": "@stonecrop/utilities",
+      "comment": "add strict null checks to improve logic",
+      "type": "patch"
+    }
+  ],
+  "packageName": "@stonecrop/utilities"
+}