Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: window undo appears to be broken #127

Closed
agzam opened this issue Sep 16, 2021 · 5 comments · Fixed by #131
Closed

regression: window undo appears to be broken #127

agzam opened this issue Sep 16, 2021 · 5 comments · Fixed by #131
Labels

Comments

@agzam
Copy link
Owner

agzam commented Sep 16, 2021

It looks like at some point windows/undo stopped working. Not a vital feature, but we probably should have a better strategy for deprecating existing functionality :)

A cursory glance did not show me any clues.

@agzam agzam added the bug label Sep 16, 2021
@jaidetree
Copy link
Collaborator

What is the expected behavior?

@Grazfather
Copy link
Collaborator

Any chance you can find the culprit with git bisect?

@agzam
Copy link
Owner Author

agzam commented Sep 16, 2021

So when you move/maximize/center window, it pushes it into the history stack, then when you undo, it should restore the window to the previous state (size and coords). Right now, I see the message in the console:

** Warning:  bind.fnl: Could not invoke action windows:undo-action

@jaidetree
Copy link
Collaborator

Thanks! That error means that if you have a binding like windows:undo-action in config.fnl, it can't find the corresponding function that the string refers to.

Replace windows:undo-action with windows:undo, I'll make a PR to make the error message more clear and update the default config.

Did write some notes on a potential migration system in #122

@agzam
Copy link
Owner Author

agzam commented Sep 16, 2021

Thank you @eccentric-j. It's both - embarrassing and heartwarming to find myself having to catch up with the new development. I can hardly keep up with you guys. You are awesome!

@agzam agzam closed this as completed Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants