fix: set 144 block delay on core proposals

give a little time for liquidity

Author: whoabuddy

contracts/dao/extensions/aibtc-core-proposals.clar

@@ -18,6 +18,7 @@
 (define-constant SELF (as-contract tx-sender))
 (define-constant VOTING_PERIOD u144) ;; 144 Bitcoin blocks, ~1 day
 (define-constant VOTING_QUORUM u95) ;; 95% of liquid supply
+(define-constant DEPLOYED_AT burn-block-height)
 
 ;; error messages
 (define-constant ERR_NOT_DAO_OR_EXTENSION (err u3000))
@@ -32,6 +33,7 @@
 (define-constant ERR_VOTE_TOO_SOON (err u3009))
 (define-constant ERR_VOTE_TOO_LATE (err u3010))
 (define-constant ERR_ALREADY_VOTED (err u3011))
+(define-constant ERR_FIRST_VOTING_PERIOD (err u3012))
 
 ;; contracts used for voting calculations
 (define-constant VOTING_TOKEN_DEX .aibtc-token-dex)
@@ -78,6 +80,8 @@
       (proposalContract (contract-of proposal))
       (liquidTokens (try! (get-liquid-supply block-height)))
     )
+    ;; at least one voting period passed
+    (asserts! (>= burn-block-height (+ DEPLOYED_AT VOTING_PERIOD)) ERR_FIRST_VOTING_PERIOD)
     ;; caller has the required balance
     (asserts! (> (unwrap! (contract-call? .aibtc-token get-balance tx-sender) ERR_FETCHING_TOKEN_DATA) u0) ERR_INSUFFICIENT_BALANCE)
     ;; proposal was not already executed

tests/dao/extensions/aibtc-onchain-messaging.test.ts

@@ -55,6 +55,7 @@ describe(`extension: ${contractName}`, () => {
     const proposalContractAddress = `${deployer}.${proposalContractName}`;
 
     // fund accounts for creating and voting on proposals
+    // TODO: consolidate as fundVoters()
     const getDaoTokensReceipts = [
       getDaoTokens(deployer, deployer, 100000000), // 100 STX
       getDaoTokens(deployer, address1, 50000000), // 50 STX
@@ -93,7 +94,8 @@ describe(`extension: ${contractName}`, () => {
     expect(constructReceipt.result).toBeOk(Cl.bool(true));
 
     // progress the chain for at-block calls
-    simnet.mineEmptyBlocks(10);
+    // and to pass first core proposal voting period
+    simnet.mineEmptyBlocks(144);
 
     // pass proposal
     const concludeProposalReceipt = passCoreProposal(

tests/error-codes.ts

@@ -45,6 +45,7 @@ export enum CoreProposalErrCode {
   ERR_VOTE_TOO_SOON,
   ERR_VOTE_TOO_LATE,
   ERR_ALREADY_VOTED,
+  ERR_FIRST_VOTING_PERIOD,
 }
 
 export enum OnchainMessagingErrCode {