Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc call for ProcessLauncher is an async function which is not needed #316

Open
unkcpz opened this issue Feb 21, 2025 · 0 comments
Open

Comments

@unkcpz
Copy link
Member

unkcpz commented Feb 21, 2025

In #297, the __call__ dunder is moved to call method and used directly in add_task_subscriber. The function is an async function, and the reason is the proc.step_until_terminal() need to be scheduled into the event loop. It can actually make the call a sync function to consistent with both message_receiver and broadcast_reveiver. In the call, the proc.execute() method is called by step the process forward.

The problem can be checked and fixed together with unkcpz#39 to have a sophisticate control on event loop. Because when initialize a process will create an event loop if it is not created in the event loop, the event loop then need to reset to the runner one to launch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant