Homework Feedback - Node Week 3

[jawkha]

Calculator Exercise

Nice work on implementing the calculator. However, there's a bug here. One of the requirements was to account for situations where the same query parameter is used multiple times, e.g. calculator/multiply?firstParam=1&secondParam=2&secondParam=4
The way you have implemented it, such queries return NaN instead of the solution due to the fact that all the values with the same query parameter (secondParam in this case) are aggregated in an array and a Number conversion operation on each query parameter without first checking whether it's a String or something else leads to this problem.

hyf-homework/nodejs/week3/calculator/index.js

Line 8 in 5c41f37

numbers.push(Number(req.query[key]));

Meal Sharing Website

Please let me know if you found it difficult to implement this part of the homework or just couldn't make time for it.