Skip to content

Commit 0034695

Browse files
authored
fix: Keep source/binary compatibility with 2.5.1 for addRequestHeader (#2022)
1 parent 33ce3b5 commit 0034695

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

runtime/src/main/scala/akka/grpc/javadsl/AkkaGrpcClient.scala

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@ trait AkkaGrpcClient {
1616
/**
1717
* @return The same client decorated to add the given key and value to the metadata of any request issued.
1818
*/
19-
def addRequestHeader(key: String, value: String): AkkaGrpcClient
19+
def addRequestHeader(key: String, value: String): AkkaGrpcClient = {
20+
// dummy implementation to not break compatibility
21+
this
22+
}
2023

2124
/**
2225
* Initiates a shutdown in which preexisting and new calls are cancelled.

runtime/src/main/scala/akka/grpc/scaladsl/AkkaGrpcClient.scala

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,8 @@ trait AkkaGrpcClient {
3333
/**
3434
* The same client instance decorated to add the given key and value to the metadata of any request issued.
3535
*/
36-
def addRequestHeader(key: String, value: String): AkkaGrpcClient
36+
def addRequestHeader(key: String, value: String): AkkaGrpcClient = {
37+
// dummy implementation to not break compatibility
38+
this
39+
}
3740
}

0 commit comments

Comments
 (0)