Protected_Locators

Author: akshayp7

package-lock.json

@@ -23,15 +23,15 @@
   "author": "Akshay Pai",
   "license": "MIT",
   "dependencies": {
-    "@playwright/test": "^1.23.2",
+    "@playwright/test": "^1.24.0",
     "@types/adm-zip": "^0.5.0",
     "@types/crypto-js": "^4.1.1",
-    "@typescript-eslint/eslint-plugin": "^5.30.5",
-    "@typescript-eslint/parser": "^5.30.5",
+    "@typescript-eslint/eslint-plugin": "^5.31.0",
+    "@typescript-eslint/parser": "^5.31.0",
     "adm-zip": "^0.5.9",
     "cross-env": "^7.0.3",
     "crypto-js": "^4.1.1",
-    "eslint": "^8.19.0",
+    "eslint": "^8.20.0",
     "eslint-plugin-import": "^2.26.0",
     "exceljs": "^4.3.0",
     "experimental-allure-playwright": "0.0.3",

package.json

@@ -1,5 +1,5 @@
 export class LoginPageObjects {
-    EMAIL_EDITBOX_ID = `#email`;
-    PASSWORD_EDITBOX_ID = `#passwd`;
-    SIGN_IN_BUTTON_ID = `#SubmitLogin`;
+    protected static EMAIL_EDITBOX_ID = `#email`;
+    protected static PASSWORD_EDITBOX_ID = `#passwd`;
+    protected static SIGN_IN_BUTTON_ID = `#SubmitLogin`;
 }

pageFactory/objectRepository/LoginPageObjects.ts

@@ -1,6 +1,6 @@
 export class MyAccountPageObjects {
-    MY_ACCOUNT_HDR_XPATH = `//h1[contains(text(),'My account')]`;
-    MY_ACCOUNT_LINKS_XPATH = `//span[contains(text(),'linkName')]`;
-    MY_ACCOUNT_FOLLOW_FB_LINK_XPATH="//span[text()='Facebook']/..";
-    MY_ACCOUNT_FB_MEMBERS_LINK_XPATH=`//a[contains(text(),'members')]`;
+    protected static MY_ACCOUNT_HDR_XPATH = `//h1[contains(text(),'My account')]`;
+    protected static MY_ACCOUNT_LINKS_XPATH = `//span[contains(text(),'linkName')]`;
+    protected static MY_ACCOUNT_FOLLOW_FB_LINK_XPATH="//span[text()='Facebook']/..";
+    protected static MY_ACCOUNT_FB_MEMBERS_LINK_XPATH=`//a[contains(text(),'members')]`;
 }

pageFactory/objectRepository/MyAccountPageObjects.ts

@@ -1,4 +1,4 @@
 export class MyAddressesPageObjects {
-    MY_ADDRESSES_HDR_XPATH = `//h1[contains(text(),'My addresses')]`;
-    ADDRESS_DETAILS_XPATH = `//h3[contains(text(),'qwert')]`;
+    protected static MY_ADDRESSES_HDR_XPATH = `//h1[contains(text(),'My addresses')]`;
+    protected static ADDRESS_DETAILS_XPATH = `//h3[contains(text(),'qwert')]`;
 }

pageFactory/objectRepository/MyAddressesPageObjects.ts

@@ -1,4 +1,4 @@
 export class MyPersonalInformationPageObjects {
-    MY_PERSONAL_INFO_HDR_XPATH = `//h1[contains(text(),'Your personal information')]`;
-    FIRST_NAME_ID = `#firstname`;
+    protected static MY_PERSONAL_INFO_HDR_XPATH = `//h1[contains(text(),'Your personal information')]`;
+    protected static FIRST_NAME_ID = `#firstname`;
 }

pageFactory/objectRepository/MyPersonalInformationPageObjects.ts

@@ -5,24 +5,23 @@ import {testConfig} from '../../testConfig';
 
 let webActions: WebActions;
 
-export class LoginPage {
+export class LoginPage extends LoginPageObjects{
     readonly page: Page;
 
     constructor(page: Page) {
+        super();
         this.page = page;
         webActions = new WebActions(this.page);
     }
 
-    loginPageObjects = new LoginPageObjects();
-
     async navigateToURL(): Promise<void> {
         await webActions.navigateToURL(`/index.php?controller=authentication&back=my-account`);
     }
 
     async loginToApplication(): Promise<void> {
         const decipherPassword = await webActions.decipherPassword();
-        await webActions.enterElementText(this.loginPageObjects.EMAIL_EDITBOX_ID, testConfig.username);
-        await webActions.enterElementText(this.loginPageObjects.PASSWORD_EDITBOX_ID, decipherPassword);
-        await webActions.clickElement(this.loginPageObjects.SIGN_IN_BUTTON_ID);
+        await webActions.enterElementText(LoginPageObjects.EMAIL_EDITBOX_ID, testConfig.username);
+        await webActions.enterElementText(LoginPageObjects.PASSWORD_EDITBOX_ID, decipherPassword);
+        await webActions.clickElement(LoginPageObjects.SIGN_IN_BUTTON_ID);
     }
 }

pageFactory/pageRepository/LoginPage.ts

@@ -4,26 +4,25 @@ import type { BrowserContext, Page } from '@playwright/test';
 
 let webActions: WebActions;
 
-export class MyAccountPage {
+export class MyAccountPage extends MyAccountPageObjects{
     readonly page: Page;
 
     constructor(page: Page) {
+        super();
         this.page = page;
         webActions = new WebActions(this.page);
     }
 
-    myAccountPageObjects = new MyAccountPageObjects();
-
     async verifyMyAccountHeader(): Promise<void> {
-        await webActions.verifyElementText(this.myAccountPageObjects.MY_ACCOUNT_HDR_XPATH, `My account`);
+        await webActions.verifyElementText(MyAccountPageObjects.MY_ACCOUNT_HDR_XPATH, `My account`);
     }
 
     async clickOnMyAccountLinks(linkName: string): Promise<void> {
-        await webActions.clickElement(this.myAccountPageObjects.MY_ACCOUNT_LINKS_XPATH.replace(`linkName`, linkName));
+        await webActions.clickElement(MyAccountPageObjects.MY_ACCOUNT_LINKS_XPATH.replace(`linkName`, linkName));
     }
 
     async verifyFollowUsFBWindowAndClickMembers(context: BrowserContext, urlText: string): Promise<void> {
-        await webActions.verifyNewWindowUrlAndClick(context, this.myAccountPageObjects.MY_ACCOUNT_FOLLOW_FB_LINK_XPATH, urlText,this.myAccountPageObjects.MY_ACCOUNT_FB_MEMBERS_LINK_XPATH);
+        await webActions.verifyNewWindowUrlAndClick(context, MyAccountPageObjects.MY_ACCOUNT_FOLLOW_FB_LINK_XPATH, urlText,MyAccountPageObjects.MY_ACCOUNT_FB_MEMBERS_LINK_XPATH);
     }
 
 }

pageFactory/pageRepository/MyAccountPage.ts

@@ -4,21 +4,20 @@ import type { Page } from '@playwright/test';
 
 let webActions: WebActions;
 
-export class MyAddressesPage {
+export class MyAddressesPage extends MyAddressesPageObjects{
     readonly page: Page;
 
     constructor(page: Page) {
+        super();
         this.page = page;
         webActions = new WebActions(this.page);
     }
 
-    myAddressesPageObjects = new MyAddressesPageObjects();
-
     async verifyMyAddressesHeader(): Promise<void> {
-        await webActions.verifyElementText(this.myAddressesPageObjects.MY_ADDRESSES_HDR_XPATH, `My addresses`);
+        await webActions.verifyElementText(MyAddressesPageObjects.MY_ADDRESSES_HDR_XPATH, `My addresses`);
     }
 
     async verifyAdressDetails(): Promise<void> {
-        await webActions.verifyElementText(this.myAddressesPageObjects.ADDRESS_DETAILS_XPATH, `qwert`);
+        await webActions.verifyElementText(MyAddressesPageObjects.ADDRESS_DETAILS_XPATH, `qwert`);
     }
 }

pageFactory/pageRepository/MyAddressesPage.ts

@@ -4,21 +4,20 @@ import type { Page } from '@playwright/test';
 
 let webActions: WebActions;
 
-export class MyPersonalInformationPage {
+export class MyPersonalInformationPage extends MyPersonalInformationPageObjects{
     readonly page: Page;
 
     constructor(page: Page) {
+        super();
         this.page = page;
         webActions = new WebActions(this.page);
     }
 
-    myPersonalInformationPageObjects = new MyPersonalInformationPageObjects();
-
     async verifyMyPersonalInfoHeader(): Promise<void> {
-        await webActions.verifyElementText(this.myPersonalInformationPageObjects.MY_PERSONAL_INFO_HDR_XPATH, `Your personal information`);
+        await webActions.verifyElementText(MyPersonalInformationPageObjects.MY_PERSONAL_INFO_HDR_XPATH, `Your personal information`);
     }
 
     async verifyFirstName(firstName: string): Promise<void> {
-        await webActions.verifyJSElementValue(this.myPersonalInformationPageObjects.FIRST_NAME_ID, firstName);
+        await webActions.verifyJSElementValue(MyPersonalInformationPageObjects.FIRST_NAME_ID, firstName);
     }
 }