Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hash_index on Big Endian #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix hash_index on Big Endian #8

wants to merge 3 commits into from

Conversation

AregevDev
Copy link

@AregevDev AregevDev commented Oct 10, 2023 •
edited
Loading

Fixes #6
I suggest squashing

@aldanor
Copy link
Owner

aldanor commented Oct 11, 2023 •
edited
Loading

Thanks - let me try to check a few things locally.

I was wondering, performance-wise on LE, does it make a difference?

@aldanor
Copy link
Owner

aldanor commented Oct 11, 2023

(Don't bother with CI errors, I'll fix them in a separate PR)

@aldanor
Copy link
Owner

aldanor commented Oct 11, 2023

@AregevDev you can now rebase on master

@AregevDev
Copy link
Author

Like this?

@AregevDev
Copy link
Author

I was wondering, performance-wise on LE, does it make a difference?
I don't think so? Those operations should behave and perform the same?

@AregevDev
Copy link
Author

I think I merged your MSRV bumb to my PR, I am sorry

@AregevDev
Copy link
Author

Hello,
Can you please review the PR a second time? If it looks good to you, you can go ahead and merge it...

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two tests fail on s390x
2 participants
@AregevDev @aldanor