Skip to content

Commit 2dba0a0

Browse files
authored
Fix/volume prompt (#267)
* fix: skip volume prompts if one is passed in parameters
1 parent 44b4ac9 commit 2dba0a0

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/aleph_client/commands/utils.py

+4-4
Original file line numberDiff line numberDiff line change
@@ -121,20 +121,20 @@ def volume_to_dict(volume: List[str]) -> Optional[Dict[str, Union[str, int]]]:
121121
def get_or_prompt_volumes(ephemeral_volume, immutable_volume, persistent_volume):
122122
volumes = []
123123
# Check if the volumes are empty
124-
if persistent_volume is None or ephemeral_volume is None or immutable_volume is None:
124+
if not any([persistent_volume, ephemeral_volume, immutable_volume]):
125125
for volume in prompt_for_volumes():
126126
volumes.append(volume)
127127
echo("\n")
128128

129129
# else parse all the volumes that have passed as the cli parameters and put it into volume list
130130
else:
131-
if len(persistent_volume) > 0:
131+
if persistent_volume:
132132
persistent_volume_dict = volume_to_dict(volume=persistent_volume)
133133
volumes.append(persistent_volume_dict)
134-
if len(ephemeral_volume) > 0:
134+
if ephemeral_volume:
135135
ephemeral_volume_dict = volume_to_dict(volume=ephemeral_volume)
136136
volumes.append(ephemeral_volume_dict)
137-
if len(immutable_volume) > 0:
137+
if immutable_volume:
138138
immutable_volume_dict = volume_to_dict(volume=immutable_volume)
139139
volumes.append(immutable_volume_dict)
140140
return volumes

0 commit comments

Comments
 (0)