Fix: Client Services Scheduler to handle 404 (#224)

* fix: `InstanceWithScheduler` to allow Optional `AllocationItem`

* fix: scheduler service `get_allocation` to handle 404

* fix: instance service `get_instance_executions_info` to handle allocations being None

Author: 1yam

src/aleph/sdk/client/services/instance.py

@@ -114,6 +114,8 @@ async def _fetch(
             if isinstance(alloc, InstanceManual):
                 crn_url = sanitize_url(alloc.crn_url)
             else:
+                if not alloc.allocations:
+                    return str(item_hash), None
                 crn_url = sanitize_url(alloc.allocations.node.url)
 
             if not crn_url:

src/aleph/sdk/client/services/scheduler.py

@@ -1,6 +1,7 @@
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, Optional
 
 import aiohttp
+from aiohttp import ClientResponseError
 from aleph_message.models import ItemHash
 
 from aleph.sdk.conf import settings
@@ -40,15 +41,18 @@ async def get_nodes(self) -> SchedulerNodes:
 
                 return SchedulerNodes.model_validate(raw)
 
-    async def get_allocation(self, vm_hash: ItemHash) -> AllocationItem:
+    async def get_allocation(self, vm_hash: ItemHash) -> Optional[AllocationItem]:
         """
         Fetch allocation information for a given VM hash.
         """
         url = f"{sanitize_url(settings.SCHEDULER_URL)}/api/v0/allocation/{vm_hash}"
-
-        async with aiohttp.ClientSession() as session:
-            async with session.get(url) as resp:
-                resp.raise_for_status()
-                payload = await resp.json()
-
-        return AllocationItem.model_validate(payload)
+        try:
+            async with aiohttp.ClientSession() as session:
+                async with session.get(url) as resp:
+                    resp.raise_for_status()
+                    payload = await resp.json()
+            return AllocationItem.model_validate(payload)
+        except ClientResponseError as e:
+            if e.status == 404:  # Allocation can't be find on scheduler
+                return None
+            raise e

src/aleph/sdk/types.py

@@ -174,7 +174,9 @@ class AllocationItem(BaseModel):
 
 class InstanceWithScheduler(BaseModel):
     source: Literal["scheduler"]
-    allocations: AllocationItem  # Case Scheduler
+    allocations: Optional[
+        AllocationItem
+    ]  # Case Scheduler (None == allocation can't be find on scheduler)
 
 
 class InstanceManual(BaseModel):