2.8.2: duplicate code

polarker · polarker · commit 70818ecb533d · 2024-08-01T07:37:22.000+02:00
diff --git a/utils/src/types/byte_string.rs b/utils/src/types/byte_string.rs
@@ -44,7 +44,6 @@ impl ByteString {
         self.current_index >= 0
     }
 
-    #[cfg(test)]
     #[inline]
     fn is_complete(&self) -> bool {
         (self.current_index as usize) == self.size()
@@ -74,7 +73,7 @@ impl RawDecoder for ByteString {
             self.current_index += 1;
         }
 
-        if (self.current_index as usize) == self.size() {
+        if self.is_complete() {
             Ok(DecodeStage::COMPLETE)
         } else {
             Ok(DecodeStage { ..*stage })

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,6 @@ impl ByteString {`
`44`	`44`	`self.current_index >= 0`
`45`	`45`	`}`
`46`	`46`
`47`		`- #[cfg(test)]`
`48`	`47`	`#[inline]`
`49`	`48`	`fn is_complete(&self) -> bool {`
`50`	`49`	`(self.current_index as usize) == self.size()`
`@@ -74,7 +73,7 @@ impl RawDecoder for ByteString {`
`74`	`73`	`self.current_index += 1;`
`75`	`74`	`}`
`76`	`75`
`77`		`- if (self.current_index as usize) == self.size() {`
	`76`	`+ if self.is_complete() {`
`78`	`77`	`Ok(DecodeStage::COMPLETE)`
`79`	`78`	`} else {`
`80`	`79`	`Ok(DecodeStage { ..*stage })`