Merge pull request bcgov#155 from sdevalapurkar/sd-code-smelling

Get code smelling better :)

Author: alexjoybc

jrcc-access-spring-boot-autoconfigure/src/test/java/ca/bc/gov/open/jrccaccess/autoconfigure/AccessPropertiesTests.java

@@ -30,7 +30,7 @@ public void with_no_explicit_sender_should_return_default() {
         properties.setInput(new AccessProperties.PluginConfig());
         PluginConfig pluginConfig = properties.getInput();
 
-        assertEquals(pluginConfig.getSender(), Constants.UNKNOWN_SENDER);
+        assertEquals(Constants.UNKNOWN_SENDER, pluginConfig.getSender());
     }
 
     @Test

jrcc-access-spring-boot-autoconfigure/src/test/java/ca/bc/gov/open/jrccaccess/autoconfigure/plugins/http/DocumentControllerTests.java

@@ -98,7 +98,7 @@ public void post_with_missing_sender_in_query_string_should_use_config_sender()
 		ResponseEntity<DocumentReceivedResponse> response = sut.postDocument(null, null, null, null, null, SERVICE_UNAVAILABLE, multipartFile);
 		assertEquals(HttpStatus.OK, response.getStatusCode());
 		assertTrue(response.getBody().getAcknowledge());
-		assertEquals(pluginConfig.getSender(), "test-sender-http");
+		assertEquals("test-sender-http", pluginConfig.getSender());
 	}
 
 	@Test

jrcc-access-spring-boot-autoconfigure/src/test/java/ca/bc/gov/open/jrccaccess/autoconfigure/plugins/sftp/SftpInputPropertiesTests.java

@@ -22,63 +22,63 @@ public void with_ssh_key_should_return_ssh_key() {
     public void with_remote_directory_should_return_remote_directory() {
         SftpInputProperties sut = new SftpInputProperties();
         sut.setRemoteDirectory("/upload");
-        Assert.assertEquals(sut.getRemoteDirectory(), "/upload");
+        Assert.assertEquals("/upload", sut.getRemoteDirectory());
     }
 
     @Test
     public void with_host_should_return_host() {
         SftpInputProperties sut = new SftpInputProperties();
         sut.setHost("localhost");
-        Assert.assertEquals(sut.getHost(), "localhost");
+        Assert.assertEquals("localhost", sut.getHost());
     }
 
     @Test
     public void with_port_should_return_integer_value_of_port() {
         SftpInputProperties sut = new SftpInputProperties();
         sut.setPort("22");
-        Assert.assertEquals(sut.getPort(), Integer.valueOf("22"));
+        Assert.assertEquals(Integer.valueOf("22"), sut.getPort());
     }
 
     @Test
     public void with_username_should_return_username() {
         SftpInputProperties sut = new SftpInputProperties();
         sut.setUsername("user");
-        Assert.assertEquals(sut.getUsername(), "user");
+        Assert.assertEquals("user", sut.getUsername());
     }
 
     @Test
     public void with_password_should_return_password() {
         SftpInputProperties sut = new SftpInputProperties();
         sut.setPassword("pass");
-        Assert.assertEquals(sut.getPassword(), "pass");
+        Assert.assertEquals("pass", sut.getPassword());
     }
 
     @Test
     public void with_cron_should_return_cron() {
         SftpInputProperties sut = new SftpInputProperties();
         sut.setCron("0/5 * * * * *");
-        Assert.assertEquals(sut.getCron(), "0/5 * * * * *");
+        Assert.assertEquals("0/5 * * * * *", sut.getCron());
     }
 
     @Test
     public void with_filter_pattern_should_return_filter_pattern() {
         SftpInputProperties sut = new SftpInputProperties();
         sut.setFilterPattern("filter-pattern");
-        Assert.assertEquals(sut.getFilterPattern(), "filter-pattern");
+        Assert.assertEquals("filter-pattern", sut.getFilterPattern());
     }
 
     @Test
     public void with_max_message_per_poll_should_return_max_message_per_poll() {
         SftpInputProperties sut = new SftpInputProperties();
         sut.setMaxMessagePerPoll("5");
-        Assert.assertEquals(sut.getMaxMessagePerPoll(), "5");
+        Assert.assertEquals("5", sut.getMaxMessagePerPoll());
     }
 
     @Test
     public void with_ssh_private_passphrase_should_return_ssh_private_passphrase() {
         SftpInputProperties sut = new SftpInputProperties();
         sut.setSshPrivatePassphrase("passphrase");
-        Assert.assertEquals(sut.getSshPrivatePassphrase(), "passphrase");
+        Assert.assertEquals("passphrase", sut.getSshPrivatePassphrase());
     }
 
     @Test
@@ -103,19 +103,19 @@ public void default_get_known_hosts_return_null() {
     @Test
     public void default_get_host_returns_localhost() {
         SftpInputProperties sut = new SftpInputProperties();
-        Assert.assertEquals(sut.getHost(), "localhost");
+        Assert.assertEquals("localhost", sut.getHost());
     }
 
     @Test
     public void default_get_port_returns_22() {
         SftpInputProperties sut = new SftpInputProperties();
-        Assert.assertEquals(sut.getPort(), Integer.valueOf("22"));
+        Assert.assertEquals(Integer.valueOf("22"), sut.getPort());
     }
 
     @Test
     public void default_get_filter_pattern_returns_empty_string() {
         SftpInputProperties sut = new SftpInputProperties();
-        Assert.assertEquals(sut.getFilterPattern(), "");
+        Assert.assertEquals("", sut.getFilterPattern());
     }
 
     @Test