Skip to content
This repository was archived by the owner on May 14, 2020. It is now read-only.

Commit fb671f1

Browse files
committed
Resolves #19: Fixed regression in displayed values that caused all values to be displayed as strings. Also fixed secondary regression that caused null or undefined values to be displayed as empty strings
1 parent 0dccc37 commit fb671f1

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/JSONValueNode.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,8 @@ export default class JSONValueNode extends React.Component {
4646
</label>
4747
<span style={{
4848
color: this.props.theme.base0B,
49-
...this.props.styles.getValueStyle('String', true)
50-
}}>"{this.props.valueRenderer(this.props.valueGetter(this.props.value))}"</span>
49+
...this.props.styles.getValueStyle(this.props.nodeType, true)
50+
}}>{this.props.valueRenderer(this.props.valueGetter(this.props.value))}</span>
5151
</li>
5252
);
5353
}

src/grab-node.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -47,17 +47,17 @@ export default function({
4747
case 'Iterable':
4848
return <JSONIterableNode {...nestedNodeProps} />;
4949
case 'String':
50-
return <JSONValueNode {...simpleNodeProps} />;
50+
return <JSONValueNode {...simpleNodeProps} valueGetter={raw => `"${raw}"`} />;
5151
case 'Number':
5252
return <JSONValueNode {...simpleNodeProps} />;
5353
case 'Boolean':
5454
return <JSONValueNode {...simpleNodeProps} valueGetter={raw => raw ? 'true' : 'false'} />;
5555
case 'Date':
5656
return <JSONValueNode {...simpleNodeProps} valueGetter={raw => raw.toISOString()} />;
5757
case 'Null':
58-
return <JSONValueNode {...simpleNodeProps} valueGetter={() => null} />;
58+
return <JSONValueNode {...simpleNodeProps} valueGetter={() => 'null'} />;
5959
case 'Undefined':
60-
return <JSONValueNode {...simpleNodeProps} valueGetter={() => undefined} />;
60+
return <JSONValueNode {...simpleNodeProps} valueGetter={() => 'undefined'} />;
6161
case 'Function':
6262
return <JSONValueNode {...simpleNodeProps} valueGetter={raw => raw.toString()} />;
6363
default:

0 commit comments

Comments
 (0)