Rubocop

Author: alexrudall

README.md

@@ -114,7 +114,7 @@ You can pass [Faraday middleware](https://lostisland.github.io/faraday/#/middlew
 
 ```ruby
   client = OpenAI::Client.new do |f|
-    f.response :logger, ::Logger.new(STDOUT), bodies: true
+    f.response :logger, Logger.new($stdout), bodies: true
   end
 ```
 

lib/openai/client.rb

@@ -11,8 +11,7 @@ class Client
       request_timeout
       extra_headers
     ].freeze
-    attr_reader *CONFIG_KEYS
-    attr_reader :faraday_middleware
+    attr_reader *CONFIG_KEYS, :faraday_middleware
 
     def initialize(config = {}, &faraday_middleware)
       CONFIG_KEYS.each do |key|

lib/openai/http.rb

@@ -78,9 +78,7 @@ def conn(multipart: false)
         f.response :json
       end
 
-      if @faraday_middleware
-        @faraday_middleware.call(connection)
-      end
+      @faraday_middleware&.call(connection)
 
       connection
     end

spec/openai/client/chat_spec.rb

@@ -31,38 +31,37 @@
           let(:messages) do
             [
               {
-                "role"=>"function",
+                "role" => "function",
                 # "name" => "function",
-                "content"=>"function"
+                "content" => "function"
               }
             ]
           end
           let(:functions) do
             [
               {
-                "name"=>"function",
-                "description"=>"function",
-                "parameters"=>
+                "name" => "function",
+                "description" => "function",
+                "parameters" =>
                   {
-                    "type"=>"object",
-                    "properties"=>{
-                      "user"=>{
-                        "type"=>"string",
-                        "description"=>"the full name of the user"
+                    "type" => "object",
+                    "properties" => {
+                      "user" => {
+                        "type" => "string",
+                        "description" => "the full name of the user"
                       }
-                    },
+                    }
                   }
-              },
+              }
             ]
           end
 
           it "raises an error containing the reason" do
             VCR.use_cassette(cassette) do
-              begin
-                response
-              rescue Faraday::Error => e
-                expect(e.response.dig(:body, "error", "message")).to eq("Missing parameter 'name': messages with role 'function' must have a 'name'.")
-              end
+              response
+            rescue Faraday::Error => e
+              expect(e.response.dig(:body, "error",
+                                    "message")).to include("Missing parameter 'name'")
             end
           end
         end

spec/openai/client/client_spec.rb

@@ -123,7 +123,7 @@
   context "with a block" do
     let(:client) do
       OpenAI::Client.new do |client|
-        client.response :logger, ::Logger.new(STDOUT), bodies: true
+        client.response :logger, Logger.new($stdout), bodies: true
       end
     end