Skip to content

Commit 87631ce

Browse files
mnaberezalexsilva
authored andcommitted
Fix deprecation warnings for cgi.parse_qs() and cgi.parse_qsl()
supervisor/tests/test_web.py::UIHandlerTests::test_handle_request_tail_html /home/travis/build/Supervisor/supervisor/supervisor/web.py:623: PendingDeprecationWarning: cgi.parse_qs is deprecated, use urlparse.parse_qs instead query_data = parse_qs(query) supervisor/tests/test_web.py::UIHandlerTests::test_handle_request_tail_html /home/travis/build/Supervisor/supervisor/supervisor/web.py:622: PendingDeprecationWarning: cgi.parse_qsl is deprecated, use urlparse.parse_qsl instead form_urlencoded = parse_qsl(data) (cherry picked from commit 9cfa816)
1 parent 184087d commit 87631ce

File tree

2 files changed

+5
-16
lines changed

2 files changed

+5
-16
lines changed

supervisor/compat.py

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -108,17 +108,7 @@ def syslog(*args):
108108
except ImportError: # pragma: no cover
109109
from sys import maxsize as maxint
110110

111-
try: # pragma: no cover
112-
from urllib.parse import parse_qs, parse_qsl
113-
except ImportError: # pragma: no cover
114-
from urlparse import parse_qs, parse_qsl
115-
116-
try: # pragma: no cover
117-
from urllib.parse import unquote, splitquery
118-
except ImportError:
119-
from urllib import unquote, splitquery
120-
121-
try: # pragma: no cover
111+
try: # pragma: no cover
122112
import http.client as httplib
123113
except ImportError: # pragma: no cover
124114
import httplib

supervisor/web.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,9 @@
88

99
import meld3
1010

11-
from supervisor.compat import urllib
12-
from supervisor.compat import parse_qs
13-
from supervisor.compat import parse_qsl
1411
from supervisor.compat import as_bytes
12+
from supervisor.compat import urllib
13+
from supervisor.compat import urlparse
1514
from supervisor.compat import as_string
1615
from supervisor.compat import PY2
1716
from supervisor.compat import unicode
@@ -611,8 +610,8 @@ def continue_request(self, data, request):
611610
query = form['QUERY_STRING']
612611

613612
# we only handle x-www-form-urlencoded values from POSTs
614-
form_urlencoded = parse_qsl(data)
615-
query_data = parse_qs(query)
613+
form_urlencoded = urlparse.parse_qsl(data)
614+
query_data = urlparse.parse_qs(query)
616615

617616
for k, v in query_data.items():
618617
# ignore dupes

0 commit comments

Comments
 (0)