Skip to content

[bug]: Support exactOptionalPropertyTypes #1587

Open
algolia/api-clients-automation
#4935
@mrmckeb

Description

@mrmckeb

Description

We're using TypeScript's stricter exactOptionalPropertyTypes in our project, which is working well - however the types shipped by Algolia are not compatible with this setting.
https://www.typescriptlang.org/tsconfig/#exactOptionalPropertyTypes

I'm happy to submit a PR. The required change is to add undefined to the optional fields, for us the issue is specifically with the package @algolia/recommend -> browser.d.ts.

For example:

-    filters?: string;
-    facetFilters?: FacetFilters;
-    optionalFilters?: OptionalFilters;
-    numericFilters?: NumericFilters;
-    tagFilters?: TagFilters;
+    filters?: string | undefined;
+    facetFilters?: FacetFilters | undefined;
+    optionalFilters?: OptionalFilters | undefined;
+    numericFilters?: NumericFilters | undefined;
+    tagFilters?: TagFilters | undefined;

Client

Recommend

Version

5.25.0

Relevant log output

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions