Skip to content

Commit 40f3beb

Browse files
millotpshortcuts
andauthored
fix(scala): prefix tags with v (#5186)
Co-authored-by: shortcuts <[email protected]>
1 parent b0a24b6 commit 40f3beb

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

clients/algoliasearch-client-scala/.github/workflows/release.yml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,14 @@ jobs:
1313
steps:
1414
- name: Checkout
1515
uses: actions/checkout@v4
16+
with:
17+
fetch-tags: true
18+
19+
- name: checkout the release tag
20+
run: |
21+
TAG=$(sed -n 's/.*version := "\(.*\)"/\1/p' version.sbt)
22+
echo "Checking out tag $TAG"
23+
git checkout "v$TAG"
1624
1725
- name: Install Java
1826
uses: actions/setup-java@v4
@@ -26,7 +34,7 @@ jobs:
2634

2735
- run: sbt ci-release
2836
env:
29-
PGP_PASSPHRASE: ${{ secrets.SIGNING_PRIVATE_KEY_PASSWORD }}
30-
PGP_SECRET: ${{ secrets.SIGNING_PRIVATE_KEY }}
37+
PGP_PASSPHRASE: ${{ secrets.PGP_PASSPHRASE }}
38+
PGP_SECRET: ${{ secrets.PGP_SECRET }}
3139
SONATYPE_USERNAME: ${{ secrets.MAVEN_CENTRAL_USERNAME }}
3240
SONATYPE_PASSWORD: ${{ secrets.MAVEN_CENTRAL_PASSWORD }}

scripts/ci/codegen/spreadGeneration.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ async function spreadGeneration(): Promise<void> {
9999
// ruby tag is already pushed by `rake release`
100100
if (IS_RELEASE_COMMIT && lang !== 'ruby') {
101101
// Go needs a 'v' prefix for tags.
102-
const tagVersion = lang === 'go' ? `v${version}` : version;
102+
const tagVersion = lang === 'go' || lang === 'scala' ? `v${version}` : version;
103103

104104
console.log(`Processing release commit, creating new release tag ('${version}') for '${lang}' repository.`);
105105

0 commit comments

Comments
 (0)