fix(specs): fix missing params and types (#772)

Author: shortcuts

.github/.cache_version

@@ -1 +1 @@
-0.0.9
+0.0.10

config/generation.config.js

@@ -28,13 +28,10 @@ module.exports = {
 
     // PHP
     '!clients/algoliasearch-client-php/*',
-    '!clients/algoliasearch-client-php/lib/*',
-    '!clients/algoliasearch-client-php/lib/Cache/**',
-    '!clients/algoliasearch-client-php/lib/Exceptions/**',
-    '!clients/algoliasearch-client-php/lib/Http/**',
-    '!clients/algoliasearch-client-php/lib/Log/**',
-    '!clients/algoliasearch-client-php/lib/RequestOptions/**',
-    '!clients/algoliasearch-client-php/lib/RetryStrategy/**',
-    '!clients/algoliasearch-client-php/lib/Support/**',
+    'clients/algoliasearch-client-php/lib/Api/*',
+    'clients/algoliasearch-client-php/lib/Model/**',
+    'clients/algoliasearch-client-php/lib/Configuration/*',
+    'clients/algoliasearch-client-php/lib/ApiException.php',
+    'clients/algoliasearch-client-php/lib/ObjectSerializer.php',
   ],
 };

generators/src/main/java/com/algolia/codegen/cts/manager/JavaCTSManager.java

@@ -15,7 +15,7 @@ public JavaCTSManager(String client) {
 
   @Override
   public void addSupportingFiles(List<SupportingFile> supportingFiles) {
-    supportingFiles.add(new SupportingFile("build.mustache", ".", "build.gradle"));
+    supportingFiles.add(new SupportingFile("build.mustache", "", "build.gradle"));
   }
 
   @Override

generators/src/main/java/com/algolia/codegen/cts/tests/ParametersWithDataType.java

@@ -305,7 +305,13 @@ private void handleModel(
       }
       if (varSpec == null) {
         throw new CTSException(
-          "Parameter " + entry.getKey() + " not found in " + paramName + ". You might have a type conflict in the spec for " + baseType
+          "Parameter '" +
+          entry.getKey() +
+          "' not found in '" +
+          paramName +
+          "'. You might have a type conflict in the spec for '" +
+          baseType +
+          "'"
         );
       }
 

scripts/ci/githubActions/createMatrix.ts

@@ -128,12 +128,7 @@ async function getSpecMatrix(): Promise<void> {
   };
 
   for (const client of CLIENTS) {
-    // `algoliasearch` is an aggregation of client
-    if (client === 'algoliasearch') {
-      continue;
-    }
-
-    // The `lite` spec is created by the `search` spec
+    // The `algoliasearch` spec is created by the `search` spec, for the `lite` JavaScript client.
     const bundledSpecName = client === 'algoliasearch' ? 'search' : client;
 
     matrix.toRun.push(client);

scripts/ci/husky/__tests__/pre-commit.test.js

@@ -24,7 +24,6 @@ describe('micromatch', () => {
 
             'clients/algoliasearch-client-php/.gitignore',
             'clients/algoliasearch-client-php/lib/Api/SearchClient.php',
-            'clients/algoliasearch-client-php/lib/Cache/FileCacheDriver.php',
 
             'tests/output/java/build.gradle',
             'tests/output/java/settings.gradle',

specs/abtesting/common/parameters.yml

@@ -22,7 +22,11 @@ endAt:
 
 createdAt:
   type: string
-  description: End date for the A/B test expressed as YYYY-MM-DDThh:mm:ssZ.
+  description: Creation date for the A/B test expressed as YYYY-MM-DDThh:mm:ssZ.
+
+updatedAt:
+  type: string
+  description: Update date for the A/B test expressed as YYYY-MM-DDThh:mm:ssZ.
 
 name:
   type: string

specs/abtesting/common/schemas/ABTest.yml

@@ -20,6 +20,8 @@ ABTest:
       description: A/B test significance based on conversion data. Should be > 0.95 to be considered significant (no matter which variant is winning).
     endAt:
       $ref: '../parameters.yml#/endAt'
+    updatedAt:
+      $ref: '../parameters.yml#/updatedAt'
     createdAt:
       $ref: '../parameters.yml#/createdAt'
     name:
@@ -34,6 +36,7 @@ ABTest:
     - name
     - createdAt
     - endAt
+    - updatedAt
     - conversionSignificance
     - clickSignificance
     - abTestID