Skip to content

Commit a56c96c

Browse files
author
ChaomingZhangCN
committed
fix tests
1 parent a5c8c53 commit a56c96c

File tree

3 files changed

+14
-14
lines changed

3 files changed

+14
-14
lines changed

src/paimon/common/sst/sst_file_io_test.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ class SstFileIOTest : public ::testing::Test {
5252
}
5353

5454
void TearDown() override {
55-
fs_->Delete(dir_->Str());
55+
ASSERT_OK(fs_->Delete(dir_->Str()));
5656
}
5757

5858
protected:
@@ -71,7 +71,7 @@ TEST_F(SstFileIOTest, TestSimple) {
7171
auto bf = BloomFilter::Create(30, 0.01);
7272
auto seg_for_bf = MemorySegment::AllocateHeapMemory(bf->ByteLength(), pool_.get());
7373
auto seg_ptr = std::make_shared<MemorySegment>(seg_for_bf);
74-
bf->SetMemorySegment(seg_ptr);
74+
ASSERT_OK(bf->SetMemorySegment(seg_ptr));
7575
auto writer = std::make_shared<SstFileWriter>(out, pool_, bf, 50);
7676
std::set<int32_t> value_hash;
7777
for (size_t i = 1; i <= 5; i++) {
@@ -120,13 +120,13 @@ TEST_F(SstFileIOTest, TestSimple) {
120120
auto entries = bloom_filter_handle->ExpectedEntries();
121121
auto offset = bloom_filter_handle->Offset();
122122
auto size = bloom_filter_handle->Size();
123-
in->Seek(offset, SeekOrigin::FS_SEEK_SET);
123+
ASSERT_OK(in->Seek(offset, SeekOrigin::FS_SEEK_SET));
124124
auto bloom_filer_bytes = Bytes::AllocateBytes(size, pool_.get());
125-
in->Read(bloom_filer_bytes->data(), bloom_filer_bytes->size());
125+
ASSERT_OK(in->Read(bloom_filer_bytes->data(), bloom_filer_bytes->size()));
126126
auto seg = MemorySegment::Wrap(std::move(bloom_filer_bytes));
127127
auto ptr = std::make_shared<MemorySegment>(seg);
128128
auto bloom_filter = std::make_shared<BloomFilter>(entries, size);
129-
bloom_filter->SetMemorySegment(ptr);
129+
ASSERT_OK(bloom_filter->SetMemorySegment(ptr));
130130
for (const auto& value : value_hash) {
131131
ASSERT_TRUE(bloom_filter->TestHash(value));
132132
}

src/paimon/common/utils/bit_set_test.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,9 +34,9 @@ TEST(BitSetTest, TestBitSet) {
3434
auto pool = GetDefaultPool();
3535
auto seg = MemorySegment::AllocateHeapMemory(1024, pool.get());
3636
auto ptr = std::make_shared<MemorySegment>(seg);
37-
bit_set->SetMemorySegment(ptr);
37+
ASSERT_OK(bit_set->SetMemorySegment(ptr));
3838
for (int i = 0; i < 100; i++) {
39-
bit_set->Set(i * 2 + 1);
39+
ASSERT_OK(bit_set->Set(i * 2 + 1));
4040
}
4141
for (int i = 0; i < 100; i++) {
4242
ASSERT_TRUE(bit_set->Get(i * 2 + 1));

src/paimon/common/utils/bloom_filter_test.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,15 @@ TEST(BloomFilterTest, TestOneSegmentBuilder) {
3535
auto bloom_filter = BloomFilter::Create(items, 0.01);
3636
auto seg = MemorySegment::AllocateHeapMemory(1024, pool.get());
3737
auto ptr = std::make_shared<MemorySegment>(seg);
38-
bloom_filter->SetMemorySegment(ptr);
38+
ASSERT_OK(bloom_filter->SetMemorySegment(ptr));
3939

4040
std::mt19937_64 engine(std::random_device{}()); // NOLINT(whitespace/braces)
4141
std::uniform_int_distribution<int32_t> distribution(0, items);
4242
std::set<int32_t> test_data;
4343
for (int32_t i = 0; i < items; i++) {
4444
int32_t random = distribution(engine);
4545
test_data.insert(random);
46-
bloom_filter->AddHash(random);
46+
ASSERT_OK(bloom_filter->AddHash(random));
4747
}
4848

4949
for (const auto& value : test_data) {
@@ -109,13 +109,13 @@ TEST(BloomFilterTest, TestBloomFilter) {
109109
// segments 1
110110
auto seg1 = MemorySegment::AllocateHeapMemory(1024, pool.get());
111111
auto ptr1 = std::make_shared<MemorySegment>(seg1);
112-
bloom_filter->SetMemorySegment(ptr1);
112+
ASSERT_OK(bloom_filter->SetMemorySegment(ptr1));
113113

114114
std::set<int32_t> test_data1;
115115
for (int32_t i = 0; i < items; i++) {
116116
int32_t random = distribution(engine);
117117
test_data1.insert(random);
118-
bloom_filter->AddHash(random);
118+
ASSERT_OK(bloom_filter->AddHash(random));
119119
}
120120
for (const auto& value : test_data1) {
121121
ASSERT_TRUE(bloom_filter->TestHash(value));
@@ -125,11 +125,11 @@ TEST(BloomFilterTest, TestBloomFilter) {
125125
std::set<int32_t> test_data2;
126126
auto seg2 = MemorySegment::AllocateHeapMemory(1024, pool.get());
127127
auto ptr2 = std::make_shared<MemorySegment>(seg2);
128-
bloom_filter->SetMemorySegment(ptr2);
128+
ASSERT_OK(bloom_filter->SetMemorySegment(ptr2));
129129
for (int32_t i = 0; i < items; i++) {
130130
int32_t random = distribution(engine);
131131
test_data2.insert(random);
132-
bloom_filter->AddHash(random);
132+
ASSERT_OK(bloom_filter->AddHash(random));
133133
}
134134
for (const auto& value : test_data2) {
135135
ASSERT_TRUE(bloom_filter->TestHash(value));
@@ -147,7 +147,7 @@ TEST(BloomFilterTest, TestBloomFilter) {
147147
}
148148

149149
// switch to segment2 and clear
150-
bloom_filter->SetMemorySegment(ptr2);
150+
ASSERT_OK(bloom_filter->SetMemorySegment(ptr2));
151151
bloom_filter->Reset();
152152
for (const auto& value : test_data2) {
153153
ASSERT_FALSE(bloom_filter->TestHash(value));

0 commit comments

Comments
 (0)