Skip to content

Commit 5c53327

Browse files
committed
examples/complete: improve the examples
1 parent 164931e commit 5c53327

File tree

5 files changed

+23
-12
lines changed

5 files changed

+23
-12
lines changed

examples/complete/main.tf

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,19 @@ data "alicloud_zones" "default" {
33
}
44

55
data "alicloud_kvstore_instance_classes" "default" {
6-
zone_id = data.alicloud_zones.default.zones.0.id
6+
zone_id = data.alicloud_zones.default.zones[0].id
77
engine = "Redis"
88
engine_version = var.redis_engine_version
99
}
1010

1111
module "vpc" {
12-
source = "alibaba/vpc/alicloud"
12+
source = "alibaba/vpc/alicloud"
13+
version = "~>1.11"
14+
1315
create = true
1416
vpc_cidr = "172.16.0.0/16"
1517
vswitch_cidrs = ["172.16.0.0/21"]
16-
availability_zones = [data.alicloud_zones.default.zones.0.id]
18+
availability_zones = [data.alicloud_zones.default.zones[0].id]
1719
}
1820

1921
resource "random_integer" "default" {
@@ -35,8 +37,8 @@ module "example" {
3537

3638
#alicloud_kvstore_instance
3739
redis_instance_name = var.redis_instance_name
38-
redis_instance_class = data.alicloud_kvstore_instance_classes.default.instance_classes.0
39-
zone_id = data.alicloud_zones.default.zones.0.id
40+
redis_instance_class = data.alicloud_kvstore_instance_classes.default.instance_classes[0]
41+
zone_id = data.alicloud_zones.default.zones[0].id
4042
vswitch_id = module.vpc.this_vswitch_ids[0]
4143
security_ips = var.security_ips
4244
redis_instance_type = "Redis"

examples/complete/outputs.tf

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
output "this_redis_instance_id" {
2-
value = module.example.this_redis_instance_id
2+
description = "redis instance id"
3+
value = module.example.this_redis_instance_id
34
}
45
output "this_alicloud_ons_instance_id" {
5-
value = module.example.this_alicloud_ons_instance_id
6+
description = "ons instance id"
7+
value = module.example.this_alicloud_ons_instance_id
68
}

examples/complete/variables.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ variable "security_ips" {
2929
variable "redis_engine_version" {
3030
description = "The specification of the redis engine version."
3131
type = string
32-
default = "4.0"
32+
default = "5.0"
3333
}
3434

3535
variable "redis_appendonly" {

examples/complete/versions.tf

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
terraform {
2+
required_version = ">= 0.13"
3+
}

outputs.tf

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,18 @@
11
output "this_alicloud_ons_instance_id" {
2-
value = alicloud_ons_instance.default.id
2+
description = "The id of the ons instance."
3+
value = alicloud_ons_instance.default.id
34
}
45

56
output "this_alicloud_ons_topic_id" {
6-
value = alicloud_ons_topic.default.id
7+
description = "The id of the ons topic."
8+
value = alicloud_ons_topic.default.id
79
}
810

911
output "this_redis_instance_id" {
10-
value = alicloud_kvstore_instance.default.id
12+
description = "The id of the redis instance."
13+
value = alicloud_kvstore_instance.default.id
1114
}
1215
output "this_vswitch_id" {
13-
value = alicloud_kvstore_instance.default.vswitch_id
16+
description = "The id of the vswitch."
17+
value = alicloud_kvstore_instance.default.vswitch_id
1418
}

0 commit comments

Comments
 (0)