[Feature] Impl RlpEcdsaTx for OpTypedTransaction

[emhane]

Component

consensus

Describe the feature you would like

Impl alloy_consensus::RlpEcdsaTx for OpTypedTransaction
https://github.com/alloy-rs/alloy/blob/a33937d9f4a1c67d5ea06e8eb9ad443ffde900f7/crates/consensus/src/transaction/rlp.rs#L7-L217

Additional context

No response

[emhane]

another one I think is easy for you if you like @htiennv

[htiennv]

thanks @emhane, i love it

[htiennv]

Hi @emhane, i see alloy_consensus::RlpEcdsaTx is not public

https://github.com/alloy-rs/alloy/blob/20d13faff78325dda42de8952e0addad31d11db7/crates/consensus/src/lib.rs#L31

[mantosh-mariner]

Hi, I would like to work on this issue. Could you assign it to me?

[varun-doshi]

Is this still open? @emhane

[emhane]

a bit divided opinion here since deposit tx isn't signed. so imo, perhaps we need a new op tx enum OpSignableTypedTransaction with same variants as OpTypedTransaction except Deposit, and new method OpTypedTransaction::as_signable which returns Option<&OpSignableTypedTransaction> for ease of use. then we can impl RlpEcdsaTx on OpSignableTransaction cc @mattsse @refcell