Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Impl OpExecutionData behaviour #421

Open
emhane opened this issue Feb 7, 2025 · 2 comments
Open

[Feature] Impl OpExecutionData behaviour #421

emhane opened this issue Feb 7, 2025 · 2 comments
Assignees
@varun-doshi
Labels
A-rpc-types-engine Area: rpc-types-engine crate

Comments

@emhane
Copy link
Collaborator

emhane commented Feb 7, 2025

Component

rpc-types-engine

Describe the feature you would like

Impl OpExecutionData behaviour. Refer to behaviour of alloy type ExecutionData.

Additional context

blocked by #417
@emhane emhane added A-rpc-types-engine Area: rpc-types-engine crate C-blocked Category: This cannot move forward until something else changes labels Feb 7, 2025
@varun-doshi
Copy link
Contributor

@emhane we would also need impl OpExecutionPayload for this

@varun-doshi varun-doshi mentioned this issue Feb 11, 2025
Merged
3 tasks
@emhane emhane removed the C-blocked Category: This cannot move forward until something else changes label Feb 11, 2025
@emhane emhane mentioned this issue Feb 11, 2025
Open
@varun-doshi
Copy link
Contributor

I can take this one

@emhane emhane moved this to In Review in Project Tracking Feb 12, 2025
@refcell refcell moved this from In Review to In Progress in Project Tracking Feb 12, 2025
@emhane emhane mentioned this issue Feb 13, 2025
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 13, 2025
@emhane
feat(l2-withdrawals): Impl conversion to block for `OpExecutionPayloa…
668c24f 
…dV4` (#435)

Ref #421
github-merge-queue bot pushed a commit that referenced this issue Feb 13, 2025
@varun-doshi @emhane
feat: impl OpExecutionData (#429)
fd14d72 
<!--
Thank you for your Pull Request. Please provide a description above and
review
the requirements below.

Bug fixes and new features should include tests.

Contributors guide:
https://github.com/alloy-rs/core/blob/main/CONTRIBUTING.md

The contributors guide includes instructions for running rustfmt and
building the
documentation.
-->

<!-- ** Please select "Allow edits from maintainers" in the PR Options
** -->

## Motivation

Ref #421 
<!--
Explain the context and why you're making that change. What is the
problem
you're trying to solve? In some cases there is not a problem and this
can be
thought of as being the motivation for your change.
-->

## Solution

Implemented some functions for `OpExecutionData` similar to
`ExecutionData` from alloy
<!--
Summarize the solution and provide any necessary context needed to
understand
the code change.
-->

## PR Checklist

- [ ] Added Tests
- [x] Added Documentation
- [ ] Breaking changes

---------

Co-authored-by: Emilia Hane <[email protected]>
@emhane emhane moved this from In Progress to In Review in Project Tracking Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@varun-doshi varun-doshi

Labels
A-rpc-types-engine Area: rpc-types-engine crate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emhane @varun-doshi