Skip to content

Commit 54ead55

Browse files
committed
Feat: Add NoUnneededImportAliasFixer (part of #94)
1 parent 851a0a3 commit 54ead55

File tree

3 files changed

+17
-4
lines changed

3 files changed

+17
-4
lines changed

Diff for: ecs.php

+7-4
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,7 @@
7676
use PhpCsFixer\Fixer\FunctionNotation\ReturnTypeDeclarationFixer;
7777
use PhpCsFixer\Fixer\FunctionNotation\VoidReturnFixer;
7878
use PhpCsFixer\Fixer\Import\NoLeadingImportSlashFixer;
79+
use PhpCsFixer\Fixer\Import\NoUnneededImportAliasFixer;
7980
use PhpCsFixer\Fixer\Import\NoUnusedImportsFixer;
8081
use PhpCsFixer\Fixer\Import\OrderedImportsFixer;
8182
use PhpCsFixer\Fixer\LanguageConstruct\DeclareEqualNormalizeFixer;
@@ -280,13 +281,15 @@
280281
ReturnTypeDeclarationFixer::class,
281282

282283
VoidReturnFixer::class,
283-
284+
// Remove leading slashes in `use` clauses.
284285
NoLeadingImportSlashFixer::class,
285-
286+
// Imports should not be aliased as the same name.
287+
NoUnneededImportAliasFixer::class,
288+
// Unused `use` statements must be removed.
286289
NoUnusedImportsFixer::class,
287-
290+
// Order `use` statements.
288291
OrderedImportsFixer::class,
289-
292+
// Equal sign in declare statement should not be surrounded by spaces.
290293
DeclareEqualNormalizeFixer::class,
291294
// Replaces `is_null($var)` expression with `null === $var`
292295
IsNullFixer::class,

Diff for: tests/Integration/Fixtures/Basic.correct.php.inc

+5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php declare(strict_types=1);
22

3+
use Bar\Foo; // NoUnneededImportAliasFixer
4+
35
class Basic
46
{
57
public const FOO = 'foo'; // ClassAttributesSeparationFixer
@@ -18,6 +20,9 @@ class Basic
1820
$className = DateTime::class;
1921
// ClassReferenceNameCasingFixer
2022
$date = new \DateTime();
23+
24+
$aliasedClass = new Foo();
25+
2126
// SingleSpaceAfterConstructFixer
2227
if ($a == $b) {
2328
return true;

Diff for: tests/Integration/Fixtures/Basic.wrong.php.inc

+5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
<?php
22

3+
use Bar\Foo as Foo; // NoUnneededImportAliasFixer
4+
35
class Basic
46
{
57
const FOO = 'foo'; // ClassAttributesSeparationFixer
@@ -17,6 +19,9 @@ class Basic
1719
$className = DateTime :: class;
1820
// ClassReferenceNameCasingFixer
1921
$date = new \datetime();
22+
23+
$aliasedClass = new Foo();
24+
2025
// SingleSpaceAfterConstructFixer
2126
if ($a == $b) { return true; }
2227
return false; // BlankLineBeforeStatementFixer

0 commit comments

Comments
 (0)