Skip to content

Commit 652527e

Browse files
committed
Feat: Empty body of function should be abberviated {} as defined in PER2.0 (part of #94)
1 parent 63c549e commit 652527e

File tree

5 files changed

+19
-5
lines changed

5 files changed

+19
-5
lines changed

Diff for: ecs.php

+3
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@
4646
use PhpCsFixer\Fixer\Basic\BracesFixer;
4747
use PhpCsFixer\Fixer\Basic\NoTrailingCommaInSinglelineFixer;
4848
use PhpCsFixer\Fixer\Basic\PsrAutoloadingFixer;
49+
use PhpCsFixer\Fixer\Basic\SingleLineEmptyBodyFixer;
4950
use PhpCsFixer\Fixer\Casing\ClassReferenceNameCasingFixer;
5051
use PhpCsFixer\Fixer\Casing\MagicMethodCasingFixer;
5152
use PhpCsFixer\Fixer\Casing\NativeFunctionCasingFixer;
@@ -228,6 +229,8 @@
228229
SetTypeToCastFixer::class,
229230
// Array index should always be written by using square braces
230231
NormalizeIndexBraceFixer::class,
232+
// Empty body of class, interface, trait, enum or function must be abbreviated as {} and placed on the same line as the previous symbol, separated by a single space.
233+
SingleLineEmptyBodyFixer::class, // Defined in PER 2.0
231234
// Values separated by a comma on a single line should not have a trailing comma.
232235
NoTrailingCommaInSinglelineFixer::class,
233236
// Multi-line arrays, arguments list and parameters list must have a trailing comma

Diff for: src/Helper/SniffClassWrapper.php

+1-3
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,7 @@
3333

3434
final class SniffClassWrapper
3535
{
36-
public function __construct(private File $file, private int $position, private Naming $naming)
37-
{
38-
}
36+
public function __construct(private File $file, private int $position, private Naming $naming) {}
3937

4038
public function getClassName(): ?string
4139
{

Diff for: tests/Integration/Fixtures/Basic.correct.php.inc

+6
Original file line numberDiff line numberDiff line change
@@ -102,4 +102,10 @@ class Basic
102102
{
103103
return $first . $third;
104104
}
105+
106+
public function emptyFunction1(): void {} // SingleLineEmptyBodyFixer
107+
108+
public function emptyFunction2(
109+
$arg,
110+
): void {} // SingleLineEmptyBodyFixer
105111
}

Diff for: tests/Integration/Fixtures/Basic.wrong.php.inc

+8
Original file line numberDiff line numberDiff line change
@@ -99,4 +99,12 @@ class Basic
9999
{
100100
return $first . $third;
101101
}
102+
103+
public function emptyFunction1(): void {
104+
} // SingleLineEmptyBodyFixer
105+
106+
public function emptyFunction2(
107+
$arg
108+
): void {
109+
} // SingleLineEmptyBodyFixer
102110
}

Diff for: tests/Integration/Fixtures/NewPhpFeatures.correct.php.inc

+1-2
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,7 @@ namespace Lmc\CodingStandard\Integration\Fixtures;
55
class NewPhpFeatures
66
{
77
public function __construct(private string $someString) // RequireConstructorPropertyPromotionSniff
8-
{
9-
}
8+
{}
109

1110
public function php80features(
1211
string|bool $foo, // TypesSpacesFixer

0 commit comments

Comments
 (0)