Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump govuk_sidekiq from 8.0.1 to 9.0.4 #1065

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 24, 2025

Bumps govuk_sidekiq from 8.0.1 to 9.0.4.

Changelog

Sourced from govuk_sidekiq's changelog.

9.0.4

  • Allow clients to pass in own value for Redis reconnect_attempts
  • Reduce Redis reconnection timeout from 15-60s to 0.05-5s

9.0.3

  • Update dependencies

9.0.2

  • Update dependencies

9.0.1

  • Allow setting of Redis SSL verify_mode to none via environment variable

9.0.0

  • Switch from using redis gem to redis-client
  • BREAKING: Remove redis-namespace dependency and support for Redis namespaces
    • Run the redis_namespace:remove_namespace rake task immediately after upgrading to to this version, to retain existing queued jobs.
  • BREAKING: Upgrade Sidekiq to version 7.0, follow these steps to upgrade:
    1. Sidekiq::Worker has been deprecated in Sidekiq 7. Replace all instances of Sidekiq::Worker with Sidekiq::Job, then rename/move your workers to be app/sidekiq/MyJob.rb instead of app/workers/MyWorker.rb.
    2. Remove the requirement for Sidekiq strict arguments from config/initializers/sidekiq.rb. This was added to include Sidekiq 7 strict arguments behaviour in Sidekiq 6, but is no longer needed to be explictly required, since this is now the default behaviour.
    3. If using sidekiq-unique-jobs, pin to < 8.0.8 until a known issue is resolved.
    4. Make any changes required based on the information in the Sidekiq 7 API migration guide.
Commits
  • 99424f4 Merge pull request #130 from alphagov/release-9.0.4
  • 04d9fee Bump to version 9.0.4
  • 3466b93 Merge pull request #129 from alphagov/snappier-retries
  • 9978648 Make Redis reconnect_attempts be client configurable
  • 6fe2f87 Reduce the time window for Sidekiq retries
  • 0d3a64c Merge pull request #128 from alphagov/dependabot/bundler/rubocop-govuk-eq-5.0.8
  • 89e3968 Update rubocop-govuk requirement from = 5.0.7 to = 5.0.8
  • 494b627 Merge pull request #127 from alphagov/dependabot/bundler/rubocop-govuk-eq-5.0.7
  • b8d08f0 Update rubocop-govuk requirement from = 5.0.6 to = 5.0.7
  • 4c6872e Merge pull request #126 from alphagov/dependabot/bundler/rubocop-govuk-eq-5.0.6
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [govuk_sidekiq](https://github.com/alphagov/govuk_sidekiq) from 8.0.1 to 9.0.4.
- [Changelog](https://github.com/alphagov/govuk_sidekiq/blob/main/CHANGELOG.md)
- [Commits](alphagov/govuk_sidekiq@v8.0.1...v9.0.4)

---
updated-dependencies:
- dependency-name: govuk_sidekiq
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Jan 24, 2025
Copy link

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

- Run rails redis_namespace:remove_namespace (no effect)
- Rename Worker files to Job files
- We've been assuming that govuk_sidekiq would give us
  the redis gem, but they've now swapped to redis-client.
  It might be worth us swapping to redis-client as well
  to keep things simple, but for the moment we ask for
  the gem we're actually using. If in future we swap,
  we should also explicitly ask for redis-client, since
  we're not only using it for sidekiq stuff, and we don't
  want a surprise like this again.
@KludgeKML KludgeKML force-pushed the dependabot/bundler/govuk_sidekiq-9.0.4 branch from 338214d to 9190a2e Compare January 28, 2025 16:58
@KludgeKML
Copy link
Contributor

I've done some tweaking to this to make it work, so I can't review it.

Copy link

@leenagupte leenagupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@KludgeKML KludgeKML merged commit 7c4a7af into main Jan 29, 2025
9 checks passed
@KludgeKML KludgeKML deleted the dependabot/bundler/govuk_sidekiq-9.0.4 branch January 29, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants