[DO NOT MERGE] Updates to template #3985
Draft
+4
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-kirwan
force-pushed
the
update-browse-page-template
branch
from
90e0e95 to
de78c95
Compare
| // content. | ||
| border-top: 1px solid $browse-header-background-colour; | ||
| margin-top: -1px; | ||
|
|
There was a problem hiding this comment.
Good spot, agree that it looks safe to remove this now, I tested in several browsers, including Chrome, Firefox, Safari and Safari on iOS, and could not see any issues.
| @@ -19,14 +19,12 @@ | |||
| <%= render "shared/browse_header", { margin_bottom: 9 } do %> | |||
| <%= render "govuk_publishing_components/components/heading", { | |||
| text: t("browse.title"), | |||
| inverse: true, | |||
| font_size: "xl", | |||
There was a problem hiding this comment.
Looks good to me, we would also want to apply the same change to the second level browse page template, for example - https://collections-pr-3985.herokuapp.com/browse/driving/clean-air-zones-emissions-electric-vehicles
There was a problem hiding this comment.
Oh great, thanks! I've updated the show_a_to_z.html and show_curated.html views and merged into the 'Update browse header style' commit.
Apply the `very-light-blue` background colour and remove inverse styles to update the text color from #fff to #0b0c0c.
jon-kirwan
force-pushed
the
update-browse-page-template
branch
from
de78c95 to
a3712e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update browse page template
https://trello.com/c/MGjSGCAM
Why
TBC
Visual Changes
See https://collections-pr-3985.herokuapp.com/browse/driving
Anything else
alphagov/govuk_publishing_components#4616
alphagov/frontend#4627
alphagov/static#3578