Merge pull request #58 from alphagov/do-not-render-a-link-when-base-path-is-not-present

Don’t render a link when Host Edition has no base_path

Author: pezholio

app/components/document/show/host_editions_table_component.rb

@@ -108,6 +108,8 @@ def sort_link(param)
   end
 
   def frontend_path(content_item)
+    return nil if content_item.base_path.nil?
+
     Plek.website_root + content_item.base_path
   end
 
@@ -125,8 +127,13 @@ def content_link_text(content_item)
   end
 
   def content_link(content_item)
-    link_to(content_link_text(content_item),
-            frontend_path(content_item), class: "govuk-link", target: "_blank", rel: "noopener")
+    path = frontend_path(content_item)
+
+    if path
+      link_to(content_link_text(content_item), path, class: "govuk-link", target: "_blank", rel: "noopener")
+    else
+      content_item.title
+    end
   end
 
   def updated_field_for(content_item)

test/components/document/show/host_editions_table_component_test.rb

@@ -144,6 +144,38 @@ def self.it_returns_unknown_user
       end
     end
 
+    describe "when a base_path is nil" do
+      let(:host_content_item) do
+        HostContentItem.new(
+          "title" => "Some title",
+          "base_path" => nil,
+          "document_type" => "document_type",
+          "publishing_app" => "publisher",
+          "last_edited_by_editor" => last_edited_by_editor,
+          "last_edited_at" => Time.zone.now.to_s,
+          "publishing_organisation" => publishing_organisation,
+          "unique_pageviews" => unique_pageviews,
+          "host_content_id" => SecureRandom.uuid,
+          "host_locale" => "en",
+          "instances" => 1,
+        )
+      end
+
+      it "Does not render a link" do
+        render_inline(
+          described_class.new(
+            caption:,
+            host_content_items:,
+            edition:,
+          ),
+        )
+
+        assert_selector "tbody" do |tbody|
+          tbody.assert_no_selector ".govuk-link", text: "#{host_content_item.title} (opens in new tab)"
+        end
+      end
+    end
+
     describe "sorting headers" do
       it "adds the table header as an anchor tag to each header" do
         render_inline(