Merge pull request #1344 from alphagov/fix-siteimprove-nil-bug

Prevent crash if policy not found
alphagov · Jan 23, 2024 · d2c5674 · d2c5674
2 parents 8f84da2 + 42bd2bd
commit d2c5674
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/app/presenters/siteimprove/policy_issues_presenter.rb b/app/presenters/siteimprove/policy_issues_presenter.rb
@@ -45,7 +45,10 @@ def policy_short_description(policy_name)
     end
 
     def policy_description(issue)
-      note = Siteimprove::FetchPolicies.new.find(issue.id).first.note
+      policy = Siteimprove::FetchPolicies.new.find(issue.id).first
+      return "No description for this policy" unless policy
+
+      note = policy.note
       note.gsub!(/https:\/\/(.+)/, "[https://\\1](https://\\1)")
       Govspeak::Document.new(note).to_html
     end