Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for Sub Facet value and sub facet link #3574

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Add rendering for Sub Facet value and sub facet link #3574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 28 additions & 11 deletions app/presenters/specialist_document_presenter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,7 @@ def finder
end

def facets
return nil unless finder

finder.dig("details", "facets")
@facets ||= finder&.dig("details", "facets")
end

def content_item_metadata
Expand Down Expand Up @@ -150,9 +148,16 @@ def friendly_facet_label(facet, value)
allowed_value = facet["allowed_values"].detect { |av| av["value"] == value }

return default_facet_value_if_not_found(facet, value) unless allowed_value
return allowed_value["label"] unless facet["filterable"]

facet_link(allowed_value["label"], allowed_value["value"], facet["key"])
label = if allowed_value["main_facet_label"].present?
[allowed_value["main_facet_label"], allowed_value["label"]].join(" - ")
else
allowed_value["label"]
end

return label unless facet["filterable"]

facet_link(label, allowed_value, facet["key"])
end

def default_facet_value_if_not_found(facet, value)
Expand All @@ -163,13 +168,25 @@ def default_facet_value_if_not_found(facet, value)
value
end

def facet_link(label, value, key)
def facet_link(label, allowed_value, key)
finder_base_path = finder["base_path"]
view_context.link_to(
label,
"#{finder_base_path}?#{key}%5B%5D=#{value}",
class: "govuk-link govuk-link--inverse",
)
url = "#{finder_base_path}?#{facet_link_query_params(allowed_value, key)}"
view_context.link_to(label, url, class: "govuk-link govuk-link--inverse")
end

def facet_link_query_params(allowed_value, key)
query_params = { "#{key}[]" => allowed_value["value"] }

if allowed_value["main_facet_value"]
main_facet = main_facet_for_sub_facet(key)
query_params["#{main_facet['key']}[]"] = allowed_value["main_facet_value"] if main_facet
end

query_params.to_query
end

def main_facet_for_sub_facet(sub_facet_key)
facets&.detect { |f| f["sub_facet_key"] == sub_facet_key }
end

def first_published_at_facet_key
Expand Down
40 changes: 40 additions & 0 deletions test/presenters/specialist_document_presenter_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,5 +330,45 @@ def example_facet(overrides = {})
presented = present_example(example)
assert Time.zone.parse(presented.published) == Time.zone.parse("2010-01-01")
end

test "Generate correct label and link for a sub facet" do
values = { "facet-key" => "main-facet-1-value", "sub-facet-key" => "sub-facet-1-value" }
facet = example_facet({
"name" => "Facet name",
"key" => "facet-key",
"sub_facet_name" => "Sub Facet name",
"sub_facet_key" => "sub-facet-key",
"nested_facet" => true,
"filterable" => true,
"allowed_values" => [
{
"label" => "Main Facet Value",
"value" => "main-facet-1-value",
},
],
})
sub_facet = example_facet({
"name" => "Sub Facet name",
"key" => "sub-facet-key",
"nested_facet" => true,
"filterable" => true,
"allowed_values" => [
{
"label" => "Sub Facet Value",
"value" => "sub-facet-1-value",
"main_facet_label" => "Main Facet Value",
"main_facet_value" => "main-facet-1-value",
},
],
})
example = example_with_finder_facets([facet, sub_facet], values)

presented = present_example(example)

expected_main_facet_link = "<a class=\"govuk-link govuk-link--inverse\" href=\"/finder-base-path?facet-key%5B%5D=main-facet-1-value\">Main Facet Value</a>"
expected_sub_facet_link = "<a class=\"govuk-link govuk-link--inverse\" href=\"/finder-base-path?facet-key%5B%5D=main-facet-1-value&amp;sub-facet-key%5B%5D=sub-facet-1-value\">Main Facet Value - Sub Facet Value</a>"
assert_equal expected_main_facet_link, presented.important_metadata["Facet name"]
assert_equal expected_sub_facet_link, presented.important_metadata["Sub Facet name"]
end
end
end
Loading