Remove left border from the super nav menu button

[MartinJJones]

What

Removed the 1px left border style, and the hide_button_left_border option from the super navigation menu component.

Why

• To align the menu button styling on gov.uk with the styling used on the gov.uk homepage
• The hide_button_left_border option is no longer as it is now removed by default

Trello card

Visual Changes

• Live preview before - https://components.publishing.service.gov.uk/component-guide/layout_super_navigation_header/default/preview
• Live preview after - https://components-gem-pr-4631.herokuapp.com/component-guide/layout_super_navigation_header/default/preview

The failing visual regression tests in Percy are expected, screenshots of how the changes will appear on GOV.UK are included below.

Mobile

Before	After

Desktop

Before	After

[jon-kirwan]

All looks good to me! I just have one additional suggestion - I think the border-left styles below can be removed since they seem to only appear when JS is disabled.

govuk_publishing_components/app/assets/stylesheets/govuk_publishing_components/components/_layout-super-navigation-header.scss

Lines 313 to 321 in 2e25311

	.gem-c-layout-super-navigation-header__navigation-item-link-inner {
	border-left: 1px solid $button-pipe-colour;
	padding: govuk-spacing(1) $after-link-padding;
	}
	.gem-c-layout-super-navigation-header__navigation-item-link-inner--blue-background {
	border-left: 0;
	border-right: 1px solid $pale-blue-colour;
	}

.

Disabling JS does show some other nav layout issues, but I'll log a separate issue for those

[MartinJJones]

All looks good to me! I just have one additional suggestion - I think the border-left styles below can be removed since they seem to only appear when JS is disabled.

@jon-kirwan good spot!, I've made the suggested change, thanks

Disabling JS does show some other nav layout issues, but I'll log a separate issue for those

Thanks, just let me know if I can help with anything on this 👍

[jon-kirwan]

Great, changes look good to me. Thanks!

Forgot to approve Percy! Done that now.