Swap inset text top margin with padding #4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AshGDS
force-pushed
the
inset-text-margin
branch
from
45dd7dc to
24fd55c
Compare
AshGDS
force-pushed
the
inset-text-margin
branch
from
24fd55c to
3b4945e
Compare
AshGDS
force-pushed
the
inset-text-margin
branch
from
3b4945e to
f028e68
Compare
AshGDS
force-pushed
the
inset-text-margin
branch
from
f028e68 to
c75ce19
Compare
JamesCGDS
reviewed
Feb 20, 2025
app/assets/stylesheets/govuk_publishing_components/components/_inset-text.scss
Outdated
Show resolved
Hide resolved
AshGDS
force-pushed
the
inset-text-margin
branch
from
c75ce19 to
13311ad
Compare
|
Thanks @JamesCGDS - should be ready for another review now. |
We're trying to standardise the margins at the parent level of components
AshGDS
force-pushed
the
inset-text-margin
branch
from
13311ad to
6ad3f73
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What / Why
<div>, as we can't change the padding directly on the existing component, as the currentpaddinghere is used for theborder-lefteffect where the border is taller than the text content. Therefore, padding had to be added to a new parent component so that the new padding doesn't affect how the component itself looks and ensures it's just used for spacing.Visual Changes
None, hopefully