Remove custom_header
and custom_layout
options
#4635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Breaking: Removes support for the
custom_header
andcustom_layout
options from layout_for_public view template, these options were originally created for and only used by GOV.UK Chat.These options only appeared to be used by GOV.UK Chat, searching GitHub for
custom_layout
andcustom_header
only returns results for the govuk_publishing_components repo:This PR essentially reverts the changes made in #4004
Trello card
Why
These options are no longer required, GOV.UK Chat now uses a custom layout instead of layout_for_public - alphagov/govuk-chat@ff58ec0
Visual Changes
The visual changes shown in Percy are expected following the removal of the
custom_header
andcustom_layout
examples