Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom_header and custom_layout options #4635

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

MartinJJones
Copy link
Contributor

@MartinJJones MartinJJones commented Feb 17, 2025

What

Breaking: Removes support for the custom_header and custom_layout options from layout_for_public view template, these options were originally created for and only used by GOV.UK Chat.

These options only appeared to be used by GOV.UK Chat, searching GitHub for custom_layout and custom_header only returns results for the govuk_publishing_components repo:

This PR essentially reverts the changes made in #4004

Trello card

Why

These options are no longer required, GOV.UK Chat now uses a custom layout instead of layout_for_public - alphagov/govuk-chat@ff58ec0

Visual Changes

The visual changes shown in Percy are expected following the removal of the custom_header and custom_layout examples

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4635 February 17, 2025 10:23 Inactive
@MartinJJones MartinJJones force-pushed the remove-custom-header-layout-options branch from a685dc4 to bf08282 Compare February 17, 2025 10:28
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4635 February 17, 2025 10:28 Inactive
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4635 February 17, 2025 10:29 Inactive
@MartinJJones MartinJJones force-pushed the remove-custom-header-layout-options branch from c9a98cf to da6455b Compare February 17, 2025 11:54
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4635 February 17, 2025 11:54 Inactive
@MartinJJones MartinJJones marked this pull request as ready for review February 17, 2025 12:06
Copy link
Contributor

@jon-kirwan jon-kirwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me 👍

Remove the `custom_header` and `custom_layout` options from layout_for_public view template, these options were originally created for and only used by GOV.UK Chat.

GOV.UK Chat now uses a custom layout instead of layout_for_public - alphagov/govuk-chat@ff58ec0

This commit essentially reverts the changes made in #4004
@MartinJJones MartinJJones force-pushed the remove-custom-header-layout-options branch from da6455b to 52b410c Compare February 18, 2025 16:14
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4635 February 18, 2025 16:15 Inactive
@MartinJJones
Copy link
Contributor Author

Rebased and resolved the merge conflict in the changelog

@MartinJJones MartinJJones merged commit 50f4d50 into main Feb 18, 2025
12 checks passed
@MartinJJones MartinJJones deleted the remove-custom-header-layout-options branch February 18, 2025 16:22
@MartinJJones MartinJJones mentioned this pull request Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants