Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow margin bottom to be configured on the table component #4638

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

AshGDS
Copy link
Contributor

@AshGDS AshGDS commented Feb 18, 2025

What / Why

Visual Changes

None - though I've added a new example in the docs, so there is a visual change in Percy.

@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4638 February 18, 2025 12:34 Inactive
@AshGDS AshGDS force-pushed the add-margin-bottom-to-table branch from ba446b7 to 61d2209 Compare February 18, 2025 14:44
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4638 February 18, 2025 14:44 Inactive
@AshGDS AshGDS force-pushed the add-margin-bottom-to-table branch from 61d2209 to 244a02f Compare February 18, 2025 15:48
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4638 February 18, 2025 15:48 Inactive
@AshGDS AshGDS marked this pull request as ready for review February 18, 2025 15:51
@AshGDS AshGDS requested a review from JamesCGDS February 18, 2025 16:03
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4638 February 20, 2025 17:16 Inactive
Copy link
Contributor

@JamesCGDS JamesCGDS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work 👍 FYI I added a commit to the end because I spotted some unrelated typos in the table component docs and thought it'd be quicker for me to fix them whilst I was there

As this isn't using the component wrapper, a custom implementation is used.
@AshGDS AshGDS force-pushed the add-margin-bottom-to-table branch from 34d1dcc to 07db142 Compare February 21, 2025 09:45
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4638 February 21, 2025 09:45 Inactive
Co-authored-by: James Chan <[email protected]>
@govuk-ci govuk-ci temporarily deployed to components-gem-pr-4638 February 21, 2025 09:47 Inactive
@AshGDS AshGDS merged commit 130a57f into main Feb 21, 2025
12 checks passed
@AshGDS AshGDS deleted the add-margin-bottom-to-table branch February 21, 2025 09:52
@AshGDS AshGDS mentioned this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants