Improve app authentication #1345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move `ApplicationController#admin_user?` into the model as `User#admin?` - Add some actual tests for `User` model (including the GDS SSO shared example suite)
- Instead of setting up authentication based on test type, use RSpec shared context - Ensure test user is actually reset after specs - Add request spec to ensure all controllers in the app are authenticated by default
This uses `ActiveSupport::CurrentAttributes` to track the current user across the request.
|
Closing in favour of improved PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves various aspects of the authentication logic in this app, including:
Usermodelafter(:all)blockApplicationControllerCurrentmodel with ActiveSupport::CurrentAttributes to help with future auditing features (we have prior art for this pattern in Whitehall)