Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update calls to textarea with the id option #1821

Merged
merged 3 commits into from
Jan 22, 2025
Merged

Update calls to textarea with the id option #1821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dfe8c0d
Update calls to textarea with the id option
andysellick Jan 20, 2025
4f8bab2
Bump components gem
andysellick Jan 22, 2025
a96cde4
Fix margin_bottom option
andysellick Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ GEM
govuk_personalisation (1.1.0)
plek (>= 1.9.0)
rails (>= 6, < 9)
govuk_publishing_components (47.0.0)
govuk_publishing_components (50.0.0)
govuk_app_config
govuk_personalisation (>= 0.7.0)
kramdown
Expand Down Expand Up @@ -309,7 +309,7 @@ GEM
i18n (1.14.7)
concurrent-ruby (~> 1.0)
io-console (0.8.0)
irb (1.15.0)
irb (1.15.1)
pp (>= 0.6.0)
rdoc (>= 4.0.0)
reline (>= 0.4.2)
Expand Down
2 changes: 1 addition & 1 deletion app/views/sites/_site_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@
},
hint: t("helpers.hint.site_form.aliases"),
name: form.field_name(:aliases),
id: field_id_attribute(form.object, :aliases),
textarea_id: field_id_attribute(form.object, :aliases),
value: form.object.aliases,
error_message: error_message(form.object, :aliases),
} %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/sites/confirm_destroy.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

<%= render "govuk_publishing_components/components/warning_text", {
text: "This will delete the #{@site.default_host.hostname} site and all the data that is associated with it.",
margin_bottom: true
margin_bottom: 6
} %>

<p class="govuk-body">In addition to the site, this action will also remove:</p>
Expand Down
Loading