Skip to content

Commit

Permalink
hide copy code when editing a block
Browse files Browse the repository at this point in the history 
so that it should not appear on the `review` page.
  • Loading branch information
@Harriethw
Harriethw committed Feb 17, 2025
1 parent f1080ef commit e08a649
Show file tree
Hide file tree
Showing 2 changed files with 80 additions and 57 deletions.
14 changes: 10 additions & 4 deletions ...er/app/components/content_block_manager/shared/embedded_objects/summary_card_component.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,16 @@ def object_keys_rows
{
key: key.titleize,
value: object[key],
data: {
module: "copy-embed-code",
"embed-code": content_block_edition.document.embed_code_for_field("#{object_type}/#{object_name}/#{key}"),
},
data: copy_embed_code(key),
}
end
end

def copy_embed_code(key)
unless is_editable
{
module: "copy-embed-code",
"embed-code": content_block_edition.document.embed_code_for_field("#{object_type}/#{object_name}/#{key}"),
}
end
end
Expand Down
123 changes: 70 additions & 53 deletions ...tent_block_manager/test/components/shared/embedded_objects/summary_card_component_test.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -45,76 +45,93 @@ class ContentBlockManager::Shared::EmbeddedObjects::SummaryCardComponentTest < V
end
end

it "renders a summary list with edit link" do
it "renders copy code buttons" do
component = ContentBlockManager::Shared::EmbeddedObjects::SummaryCardComponent.new(
content_block_edition:,
object_type: "embedded-objects",
object_name: "my-embedded-object",
is_editable: true,
)

render_inline component

assert_selector ".govuk-summary-card__title", text: "Embedded Object details"

expected_edit_path = edit_embedded_object_content_block_manager_content_block_edition_path(
content_block_edition,
object_type: "embedded-objects",
object_name: "my-embedded-object",
)

assert_selector ".govuk-summary-card__actions .govuk-summary-card__action:nth-child(1) a[href='#{expected_edit_path}']", text: "Edit"

assert_selector ".govuk-summary-list__row", text: /Name/ do
assert_selector ".govuk-summary-list__key", text: "Name"
assert_selector ".govuk-summary-list__value", text: "My Embedded Object"
end

assert_selector ".govuk-summary-list__row", text: /Field 1/ do
assert_selector ".govuk-summary-list__key", text: "Field 1"
assert_selector ".govuk-summary-list__value", text: "Value 1"
end
assert_selector ".govuk-summary-list__row[data-embed-code='#{content_block_edition.document.embed_code_for_field('embedded-objects/my-embedded-object/name')}']", text: "Name"
assert_selector ".govuk-summary-list__row[data-embed-code='#{content_block_edition.document.embed_code_for_field('embedded-objects/my-embedded-object/field-1')}']", text: "Field 1"
assert_selector ".govuk-summary-list__row[data-embed-code='#{content_block_edition.document.embed_code_for_field('embedded-objects/my-embedded-object/field-2')}']", text: "Field 2"
end

assert_selector ".govuk-summary-list__row", text: /Field 2/ do
assert_selector ".govuk-summary-list__key", text: "Field 2"
assert_selector ".govuk-summary-list__value", text: "Value 2"
describe "when card is editable" do
it "renders a summary list with edit link" do
component = ContentBlockManager::Shared::EmbeddedObjects::SummaryCardComponent.new(
content_block_edition:,
object_type: "embedded-objects",
object_name: "my-embedded-object",
is_editable: true,
)

render_inline component

assert_selector ".govuk-summary-card__title", text: "Embedded Object details"

expected_edit_path = edit_embedded_object_content_block_manager_content_block_edition_path(
content_block_edition,
object_type: "embedded-objects",
object_name: "my-embedded-object",
)

assert_selector ".govuk-summary-card__actions .govuk-summary-card__action:nth-child(1) a[href='#{expected_edit_path}']", text: "Edit"

assert_selector ".govuk-summary-list__row", text: /Name/ do
assert_selector ".govuk-summary-list__key", text: "Name"
assert_selector ".govuk-summary-list__value", text: "My Embedded Object"
end

assert_selector ".govuk-summary-list__row", text: /Field 1/ do
assert_selector ".govuk-summary-list__key", text: "Field 1"
assert_selector ".govuk-summary-list__value", text: "Value 1"
end

assert_selector ".govuk-summary-list__row", text: /Field 2/ do
assert_selector ".govuk-summary-list__key", text: "Field 2"
assert_selector ".govuk-summary-list__value", text: "Value 2"
end
end
end

it "renders a summary list with edit link and redirect url if provided" do
component = ContentBlockManager::Shared::EmbeddedObjects::SummaryCardComponent.new(
content_block_edition:,
object_type: "embedded-objects",
object_name: "my-embedded-object",
is_editable: true,
redirect_url: "https://example.com",
)
it "renders a summary list with edit link and redirect url if provided" do
component = ContentBlockManager::Shared::EmbeddedObjects::SummaryCardComponent.new(
content_block_edition:,
object_type: "embedded-objects",
object_name: "my-embedded-object",
is_editable: true,
redirect_url: "https://example.com",
)

render_inline component
render_inline component

assert_selector ".govuk-summary-card__title", text: "Embedded Object details"
assert_selector ".govuk-summary-card__title", text: "Embedded Object details"

expected_edit_path = edit_embedded_object_content_block_manager_content_block_edition_path(
content_block_edition,
object_type: "embedded-objects",
object_name: "my-embedded-object",
redirect_url: "https://example.com",
)
expected_edit_path = edit_embedded_object_content_block_manager_content_block_edition_path(
content_block_edition,
object_type: "embedded-objects",
object_name: "my-embedded-object",
redirect_url: "https://example.com",
)

assert_selector ".govuk-summary-card__actions .govuk-summary-card__action:nth-child(1) a[href='#{expected_edit_path}']", text: "Edit"
end
assert_selector ".govuk-summary-card__actions .govuk-summary-card__action:nth-child(1) a[href='#{expected_edit_path}']", text: "Edit"
end

it "renders copy code buttons" do
component = ContentBlockManager::Shared::EmbeddedObjects::SummaryCardComponent.new(
content_block_edition:,
object_type: "embedded-objects",
object_name: "my-embedded-object",
)
it "does not render copy code button" do
component = ContentBlockManager::Shared::EmbeddedObjects::SummaryCardComponent.new(
content_block_edition:,
object_type: "embedded-objects",
object_name: "my-embedded-object",
is_editable: true,
)

render_inline component
render_inline component

assert_selector ".govuk-summary-list__row[data-embed-code='#{content_block_edition.document.embed_code_for_field('embedded-objects/my-embedded-object/name')}']", text: "Name"
assert_selector ".govuk-summary-list__row[data-embed-code='#{content_block_edition.document.embed_code_for_field('embedded-objects/my-embedded-object/field-1')}']", text: "Field 1"
assert_selector ".govuk-summary-list__row[data-embed-code='#{content_block_edition.document.embed_code_for_field('embedded-objects/my-embedded-object/field-2')}']", text: "Field 2"
assert_no_selector ".govuk-summary-list__row[data-embed-code='#{content_block_edition.document.embed_code_for_field('embedded-objects/my-embedded-object/name')}']", text: "Name"
assert_no_selector ".govuk-summary-list__row[data-embed-code='#{content_block_edition.document.embed_code_for_field('embedded-objects/my-embedded-object/field-1')}']", text: "Field 1"
assert_no_selector ".govuk-summary-list__row[data-embed-code='#{content_block_edition.document.embed_code_for_field('embedded-objects/my-embedded-object/field-2')}']", text: "Field 2"
end
end
end

0 comments on commit e08a649

Please sign in to comment.