Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start importing the visual editor style #8779

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Start importing the visual editor style #8779

merged 2 commits into from
Jan 30, 2024

Conversation

dnkrj
Copy link
Contributor

@dnkrj dnkrj commented Jan 30, 2024

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

What

  • Add and import for the visual editor styles to the govspeak editor css

Why

  • It's needed to render the visual edit
  • This could not be done previously as the visual editor css included the govuk fonts

dnkrj added 2 commits January 30, 2024 16:13
@dnkrj
Start importing the visual editor style
9f46e68 
The visual editor has been updated to not include the govuk fonts and consequently can be imported
@dnkrj
Bump govspeak-visual-editor version
2b06d1e
@lauraghiorghisor-tw lauraghiorghisor-tw force-pushed the 2319-add-visual-editor-as-a-dependency-2 branch from cf4aa11 to 2b06d1e Compare January 30, 2024 16:30
@dnkrj dnkrj merged commit 1a222d9 into main Jan 30, 2024
20 checks passed
@dnkrj dnkrj deleted the 2319-add-visual-editor-as-a-dependency-2 branch January 30, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lauraghiorghisor-tw lauraghiorghisor-tw lauraghiorghisor-tw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dnkrj @lauraghiorghisor-tw