Fix issue where [nil] is presented when no contacts
#8781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were including an array containing a single value of `nil`, if a worldwide organisation had no contacts. This is not valid against the schema. Therefore updating to publish an empty array instead.
brucebolt
force-pushed
the
fix-wworg-contacts
branch
from
6b0c28e to
562497d
Compare
| @@ -90,6 +90,8 @@ def home_page_offices | |||
| end | |||
|
|
|||
| def contacts | |||
| return [] unless item.main_office&.contact || item.home_page_offices&.map(&:contact)&.any? | |||
There was a problem hiding this comment.
would it be good to pull item.main_office&.contact and item.home_page_offices&.map(&:contact) into variables? As is they're used in a few places, not just in this file and am thinking it might be a bit easier to read
These pieces of code are used in multiple places, so can be DRY-ed up on a model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were including an array containing a single value of
nil, if a worldwide organisation had no contacts.This is not valid against the schema. Therefore updating to publish an empty array instead.
Trello card
Follow these steps if you are doing a Rails upgrade.