content modelling/899 copy embed code #9942
Conversation
this requires an external method to calculate what the actual field path is, which feels a bit brittle, but not sure what the solution would be atm - in future maybe a service or helper that find the path given the object type and schema?
the 'copy embed code' module only works with the original govuk component - I don't think there is any impactful difference, and this allows us to be up to date with the latest GDS changes.
we will also use this to determine whether to show the copy code button
Harriethw
force-pushed
the
content-modelling/899-copy-embed-code
branch
from
e08a649 to
b98df20
Compare
| @@ -16,10 +16,18 @@ def title | |||
| end | |||
|
|
|||
| def rows | |||
| object_keys_rows | |||
There was a problem hiding this comment.
don't think this actually needs to be a new method!
There was a problem hiding this comment.
Nah, you're right, just move the code from object_keys_rows to here I reckon. Cuts down on the misdirection.
| "#{embed_code_prefix}}}" | ||
| end | ||
|
|
||
| def embed_code_for_field(field_path) |
There was a problem hiding this comment.
I think this is OK for now, but yeah, I think we can probably do something a bit smarter given the schema etc
| @@ -16,10 +16,18 @@ def title | |||
| end | |||
|
|
|||
| def rows | |||
| object_keys_rows | |||
There was a problem hiding this comment.
Nah, you're right, just move the code from object_keys_rows to here I reckon. Cuts down on the misdirection.
| object_keys_rows | ||
| end | ||
|
|
||
| def object_keys_rows | ||
| object.keys.map do |key| | ||
| { | ||
| key: key.titleize, | ||
| value: object[key], |
There was a problem hiding this comment.
I think we need to have the embed code outputted here too, then hidden when we initialize the copy-embed-code JS module.
There was a problem hiding this comment.
ah yeah I meant to say I'd pick the no-JS option up in another PR!
There was a problem hiding this comment.
as the new design is a bit different and I think will mean changes to the actual javascript https://trello.com/c/Hr1mmk1C/899-add-copy-embed-code-to-attributes?filter=label:Dev
so that it should not appear on the `review` page.
Harriethw
force-pushed
the
content-modelling/899-copy-embed-code
branch
from
b98df20 to
dfd5983
Compare
https://trello.com/c/Hr1mmk1C/899-add-copy-embed-code-to-attributes
Adding the 'copy code' to specific attributes on a rate.
This involves first calculating what the embed code is for the nested field, then adding the module to the row in the summary card.
The copy code should only appear next to Amount for MVP, but that can be done in future PR.
Follow these steps if you are doing a Rails upgrade.