(910) Don’t change the object key when changing the name #9947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pezholio
force-pushed
the
content-modelling/910-bug-editing-the-name-of-a-rate-causes-embed-code-to-break
branch
from
57ac55c to
d77789d
Compare
This avoids the issue where changing the name of a rate breaks the embed code. It does mean that once a name is set, this means the key of the object is immutable, but this is a similar issue to how slugs work in other documents. We can revisit this if it becomes an issue.
pezholio
force-pushed
the
content-modelling/910-bug-editing-the-name-of-a-rate-causes-embed-code-to-break
branch
from
d77789d to
d856099
Compare
Harriethw
approved these changes
Feb 19, 2025
pezholio
deleted the
content-modelling/910-bug-editing-the-name-of-a-rate-causes-embed-code-to-break
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card: https://trello.com/c/TbeX7mVC/910-bug-editing-the-name-of-a-rate-causes-embed-code-to-break
This avoids the issue where changing the name of a rate breaks the embed code. It does mean that once a name is set, this means the key of the object is immutable, but this is a similar issue to how slugs work in other documents. We can revisit this if it becomes an issue.