Retire the 'select with search' component in favour of 'autocomplete' #9970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It made no sense for this to be a "Grouped option" select (which is only officially supported by the 'select with search' component), as at time of writing there are over 1200 orgs in total. No publisher is going to benefit from scrolling all the way down the long list of orgs to see which ones sit under "Live organisations" vs which ones sit under "Closed organisations". They're simply going to search for the relevant org - something that is fully supported by the 'autocomplete' component provided we go with `options` rather than `grouped_options`. It looks like the decision to put these into grouped options was made 11 years ago, primarily to avoid having two separate dropdown inputs. It's not clear whether one simple input without group options was ever considered: 8b02269
This dropdown has just 20 options, so doesn't particularly need search functionality. It does have a nice grouping of publication types as to whether they're commonly used, less commonly used, or 'use discouraged'. I tried simply swapping 'select with search' out for 'select', but the govuk_publishing_components [select component](https://components.publishing.service.gov.uk/component-guide/select) doesn't support grouped options. Ideally we would port the existing 'select with search' grouped options styles over to the 'select' component and then release a new version of 'govuk_publishing_components', but there's little evidence it would be used outside of just two cases in Whitehall, so it may be a difficult case to make, and in the meantime, we want to retire the 'select with search' component. I've therefore swapped this over to use the 'autocomplete' component instead. We lose the nice 'grouping' of options, but I've added a prefix to the 'less common' and 'use discouraged' publication types to keep some degree of visual separation. NB: I've reworded the latter to 'deprecated' as it works better as a prefix, and because if the use of these types is discouraged then they are by definition not well supported.
Rife with problems I'm afraid: On page load it looks ok:  But on focus, it looks as though there are no options available:  You then have to delete the pre-selected option to see what's available:  NB, here's what the 'subtypes' look like now we don't have grouped options: 
These didn't have 'grouped_options' so were simple enough to port across.
ChrisBAshton
force-pushed
the
remove-select_with_search
branch
from
06d5e76 to
3d5452a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is superseded by #9959.
This is a POC PR that removes the 'select_with_search' component and migrates all existing usage to either:
Before merging, we would need to fix the issue whereby autocomplete auto-selects the first option (when 'multiple' isn't set) and you have to clear it to even see what the other options are:
Trello: https://trello.com/c/pmbL2yId/3411-consolidate-the-autocomplete-selectwithsearch-components-in-whitehall
Follow these steps if you are doing a Rails upgrade.