Multiple creation isolate

Author: libragliese581

module/src/CScriptRuntimeInfo.h

@@ -1,4 +1,4 @@
-#pragma once
+#pragma once
 
 #include "v8.h"
 #include <libplatform/libplatform.h>
@@ -12,6 +12,14 @@ class CScriptRuntimeInfo
 public:
     v8::Isolate* GetIsolate() { return isolate; }
 
+    v8::Isolate* MakeIsolate()
+    {
+        auto createParams = v8::Isolate::CreateParams{};
+        createParams.array_buffer_allocator = v8::ArrayBuffer::Allocator::NewDefaultAllocator();
+
+        return v8::Isolate::New(createParams);
+    }
+
     void Instanciate()
     {
         v8::V8::SetFlagsFromString("--harmony-import-assertions --short-builtin-calls --no-lazy --no-flush-bytecode --no-enable-lazy-source-positions");
@@ -20,10 +28,7 @@ class CScriptRuntimeInfo
 
         v8::V8::Initialize();
 
-        auto createParams = v8::Isolate::CreateParams{};
-        createParams.array_buffer_allocator = v8::ArrayBuffer::Allocator::NewDefaultAllocator();
-
-        isolate = v8::Isolate::New(createParams);
+        isolate = MakeIsolate();
     }
 
     static CScriptRuntimeInfo& Instance()

module/src/runtime.cpp

@@ -7,7 +7,7 @@
 
 void JSBytecodeRuntime::ProcessClientFile(alt::IResource* resource, alt::IPackage* package)
 {
-    v8::Isolate* isolate = CScriptRuntimeInfo::Instance().GetIsolate();
+    v8::Isolate* isolate = CScriptRuntimeInfo::Instance().MakeIsolate();
     v8::Isolate::Scope isolateScope(isolate);
     v8::HandleScope handleScope(isolate);
 
@@ -79,7 +79,6 @@ void JSBytecodeRuntime::ProcessClientFile(alt::IResource* resource, alt::IPackag
         package->WriteFile(clientPkgFile, buffer.data(), buffer.size());
         package->CloseFile(clientPkgFile);
     }
-
     compilerLogger.Log("Converted " + std::to_string(compiledFiles.size()) + " script files to bytecode");
 }