Fix a crash on Windows when saving the stale content of an evicted app window

Ahmed Fakhry · Commit Bot · commit f28943908ef0 · 2020-01-09T18:13:13.000Z
This is only supported on ChromeOS, so make it conditional and follow the example of Browser::ShouldShowStaleContentOnEviction(): https://cs.chromium.org/chromium/src/chrome/browser/ui/browser.cc?dr=CSs&q=Browser::ShouldShowStaleContentOnEviction&g=0&l=1453 BUG=1036760 Change-Id: Idcf003483600046a4e64ebe0b681bbdb30b8449a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992515 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#729809}
diff --git a/extensions/browser/app_window/app_window.cc b/extensions/browser/app_window/app_window.cc
@@ -455,7 +455,11 @@ void AppWindow::ExitPictureInPicture() {
 }
 
 bool AppWindow::ShouldShowStaleContentOnEviction(content::WebContents* source) {
+#if defined(OS_CHROMEOS)
   return true;
+#else
+  return false;
+#endif  // defined(OS_CHROMEOS)
 }
 
 bool AppWindow::OnMessageReceived(const IPC::Message& message,

Original file line number	Diff line number	Diff line change
`@@ -455,7 +455,11 @@ void AppWindow::ExitPictureInPicture() {`
`455`	`455`	`}`
`456`	`456`
`457`	`457`	`bool AppWindow::ShouldShowStaleContentOnEviction(content::WebContents* source) {`
	`458`	`+#if defined(OS_CHROMEOS)`
`458`	`459`	`return true;`
	`460`	`+#else`
	`461`	`+ return false;`
	`462`	`+#endif // defined(OS_CHROMEOS)`
`459`	`463`	`}`
`460`	`464`
`461`	`465`	`bool AppWindow::OnMessageReceived(const IPC::Message& message,`