Skip to content

Commit 5746745

Browse files
authored
[dy] Fix DBT logging (mage-ai#4577)
1 parent 66d410d commit 5746745

File tree

4 files changed

+13
-9
lines changed

4 files changed

+13
-9
lines changed

mage_ai/data_preparation/logging/logger.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,12 @@ def log(self, log_level, message, **kwargs):
3838
def warning(self, message, **kwargs):
3939
self.__send_message('warning', message, **kwargs)
4040

41+
def warn(self, message, **kwargs):
42+
"""
43+
Same as warning, but in some cases we may need to use warn instead of warning
44+
"""
45+
self.__send_message('warning', message, **kwargs)
46+
4147
def __send_message(
4248
self,
4349
method_name,
@@ -80,6 +86,7 @@ def __getattr__(self, method_name):
8086
'info',
8187
'log',
8288
'warning',
89+
'warn',
8390
]:
8491
return getattr(self.logger, method_name)
8592
return getattr(self, method_name)

mage_ai/data_preparation/models/block/dbt/constants.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,3 +21,5 @@ class Flag(str, Enum):
2121
class LogLevel(str, Enum):
2222
DEBUG = 'debug'
2323
INFO = 'info'
24+
WARN = 'warn'
25+
ERROR = 'error'

mage_ai/data_preparation/models/block/dbt/dbt_cli.py

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,15 +15,10 @@
1515

1616
def build_logging_callback(logging_func: Callable, log_level: LogLevel = None):
1717
def __callback(event, log_level=log_level, logging_func=logging_func):
18-
# print('event.info', event.info)
19-
# print('event.data', event.data)
20-
# print(dir(event))
21-
log_levels = {
22-
LogLevel.INFO: True,
23-
}
18+
log_levels = set([LogLevel.INFO, LogLevel.WARN, LogLevel.ERROR])
2419

2520
if LogLevel.DEBUG == log_level or event.info.level in log_levels:
26-
logging_func(event.info.msg)
21+
logging_func(event.info.level, event.info.msg)
2722

2823
return __callback
2924

@@ -58,7 +53,7 @@ def invoke(
5853
dbt = dbtRunner(
5954
callbacks=[
6055
build_logging_callback(
61-
self.__debug if LogLevel.DEBUG == log_level else self.__info,
56+
self.__log,
6257
log_level=log_level,
6358
),
6459
],

mage_ai/frontend/components/Logs/Table/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ function LogsTable({
150150
uuid,
151151
} = logData || {};
152152

153-
let displayText = message || content;
153+
let displayText = message == null ? content : message;
154154
if (Array.isArray(displayText)) {
155155
displayText = displayText.join(' ');
156156
} else if (typeof displayText === 'object') {

0 commit comments

Comments
 (0)