Skip to content

Commit 26d81ec

Browse files
authored
Merge pull request #120 from Dhruv-deriv/dhruv/AccountBannerModification/TRAH-4030
Dhruv/Account-banner-modification/TRAH-4030
2 parents f607e15 + 0d21d5f commit 26d81ec

File tree

9 files changed

+44
-47
lines changed

9 files changed

+44
-47
lines changed

packages/account/src/Configs/get-mt5-status-badge-config.tsx

+11-23
Original file line numberDiff line numberDiff line change
@@ -10,39 +10,27 @@ const getMT5StatusBadgeConfig = (mt5_account_status: TMT5AccountStatus) => {
1010
switch (mt5_account_status) {
1111
case MT5_ACCOUNT_STATUS.PENDING:
1212
return {
13-
text: (
14-
<Localize
15-
i18n_default_text='<0>Pending verification</0>'
16-
components={[<Text key={0} weight='bold' size='xxxs' color='var(--status-warning)' />]}
17-
/>
18-
),
19-
icon: 'IcAlertWarning',
13+
text: <Localize i18n_default_text='In review' />,
14+
icon: 'IcMt5Pending',
2015
};
2116
case MT5_ACCOUNT_STATUS.FAILED:
2217
return {
2318
text: (
2419
<Localize
25-
i18n_default_text='<0>Verification failed.</0> <1>Why?</1>'
26-
components={[
27-
<Text key={0} weight='bold' size='xxxs' color='var(--status-danger)' />,
28-
<Text key={1} className='link-verification-failed' />,
29-
]}
20+
i18n_default_text='Failed'
21+
onClick={() => {
22+
//TODO: default jurisdiction;
23+
}}
3024
/>
3125
),
32-
icon: 'IcRedWarning',
26+
icon: 'IcMt5Failed',
27+
icon_size: '18',
3328
};
3429
case MT5_ACCOUNT_STATUS.NEEDS_VERIFICATION: {
3530
return {
36-
text: (
37-
<Localize
38-
i18n_default_text='<0>Needs verification.</0><1>Verify now</1>'
39-
components={[
40-
<Text key={0} weight='bold' size='xxxs' color='var(--status-info)' />,
41-
<Text key={1} className='link-need-verification' />,
42-
]}
43-
/>
44-
),
45-
icon: 'IcAlertInfo',
31+
text: <Localize i18n_default_text='Needs Verification' />,
32+
icon: 'IcMt5Verification',
33+
icon_size: '18',
4634
};
4735
}
4836
case MT5_ACCOUNT_STATUS.MIGRATED_WITH_POSITION:

packages/appstore/src/components/containers/trading-app-card.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ const TradingAppCard = ({
8787
link_to: '',
8888
};
8989

90-
const { text: badge_text, icon: badge_icon } = getMT5StatusBadgeConfig(mt5_acc_auth_status);
90+
const { text: badge_text, icon: badge_icon, icon_size: badge_size } = getMT5StatusBadgeConfig(mt5_acc_auth_status);
9191

9292
const handleStatusBadgeClick = (mt5_acc_auth_status: string) => {
9393
switch (mt5_acc_auth_status) {
@@ -229,6 +229,7 @@ const TradingAppCard = ({
229229
account_status={mt5_acc_auth_status}
230230
icon={badge_icon}
231231
text={badge_text}
232+
icon_size={badge_size}
232233
onClick={() => {
233234
setAppstorePlatform(platform);
234235
handleStatusBadgeClick(mt5_acc_auth_status);

packages/components/src/components/icon/icons.js

+3
Original file line numberDiff line numberDiff line change
@@ -743,6 +743,7 @@ import './mt5/ic-mt5-device-laptop.svg';
743743
import './mt5/ic-mt5-device-phone.svg';
744744
import './mt5/ic-mt5-device-tablet.svg';
745745
import './mt5/ic-mt5-expired.svg';
746+
import './mt5/ic-mt5-failed.svg';
746747
import './mt5/ic-mt5-financial-platform.svg';
747748
import './mt5/ic-mt5-financial-stp-platform.svg';
748749
import './mt5/ic-mt5-financial-stp.svg';
@@ -756,6 +757,7 @@ import './mt5/ic-mt5-one-password.svg';
756757
import './mt5/ic-mt5-open-markets.svg';
757758
import './mt5/ic-mt5-password-updated.svg';
758759
import './mt5/ic-mt5-password.svg';
760+
import './mt5/ic-mt5-pending.svg';
759761
import './mt5/ic-mt5-responsive.svg';
760762
import './mt5/ic-mt5-standard-financial-bvi.svg';
761763
import './mt5/ic-mt5-standard-financial-vanuatu.svg';
@@ -775,6 +777,7 @@ import './mt5/ic-mt5-vanuatu-derived.svg';
775777
import './mt5/ic-mt5-vanuatu-financial.svg';
776778
import './mt5/ic-mt5-vanuatu-standard.svg';
777779
import './mt5/ic-mt5-vanuatu.svg';
780+
import './mt5/ic-mt5-verification.svg';
778781
import './mt5/ic-mt5-zero-spread.svg';
779782
import './option/ic-option-accumulators.svg';
780783
import './option/ic-option-call-put-reset.svg';
Loading
Loading
Loading

packages/components/src/components/status-badge/status-badge.scss

+19-21
Original file line numberDiff line numberDiff line change
@@ -6,25 +6,40 @@
66
&__container {
77
display: inline-flex;
88
padding: 2px 7px;
9-
color: var(--status-info);
109
border-radius: 4px;
11-
border: 1.5px solid var(--status-info);
1210
align-items: center;
1311
white-space: nowrap;
12+
font-size: var(--text-size-xxxs);
13+
14+
&--pending {
15+
color: var(--status-warning);
16+
background-color: var(--status-warning-transparent);
17+
text-decoration: underline;
18+
font-weight: bold;
19+
}
20+
21+
&--needs_verification {
22+
background-color: var(--status-info-transparent);
23+
color: var(--status-info);
24+
text-decoration: underline;
25+
font-weight: bold;
26+
}
1427

1528
&--migrated_with_position,
1629
&--migrated_without_position,
17-
&--pending,
1830
&--under_maintenance,
1931
&--unavailable {
20-
border-color: var(--status-warning);
32+
border: 1.5px solid var(--status-warning);
2133
color: var(--status-warning);
2234
font-size: var(--text-size-xxxs);
2335
align-items: center;
2436
}
2537
&--failed {
2638
border-color: var(--status-danger);
2739
color: var(--status-danger);
40+
font-weight: bold;
41+
text-decoration: underline;
42+
background-color: var(--status-danger-transparent);
2843
}
2944

3045
&--icon {
@@ -36,20 +51,3 @@
3651
}
3752
}
3853
}
39-
40-
.link-need-verification {
41-
color: var(--status-info);
42-
font-weight: bold;
43-
cursor: pointer;
44-
font-size: var(--text-size-xxxs);
45-
padding-left: 0.3rem;
46-
text-decoration: underline;
47-
}
48-
49-
.link-verification-failed {
50-
color: var(--status-danger);
51-
font-weight: bold;
52-
text-decoration: underline;
53-
font-size: var(--text-size-xxxs);
54-
cursor: pointer;
55-
}

packages/components/src/components/status-badge/status-badge.tsx

+4-2
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,14 @@ type TStatusBadgeProps = {
77
account_status: string | null;
88
icon: string;
99
text: ReactNode;
10+
icon_size: string;
1011
onClick?: () => void;
1112
};
1213

1314
const StatusBadge = ({
1415
account_status,
1516
icon,
17+
icon_size = '11',
1618
text,
1719
className,
1820
onClick,
@@ -29,10 +31,10 @@ const StatusBadge = ({
2931
<div
3032
className={classNames(
3133
'switcher-status-badge__container--icon',
32-
`switcher-status-badge__container--icon${account_status ?? 'failed'}`
34+
`switcher-status-badge__container--icon--${account_status ?? 'failed'}`
3335
)}
3436
>
35-
<Icon icon={icon} size='11' />
37+
<Icon icon={icon} size={icon_size} />
3638
</div>
3739
{text}
3840
</div>

packages/shared/src/styles/themes.scss

+2
Original file line numberDiff line numberDiff line change
@@ -157,11 +157,13 @@
157157
--status-default: #{$color-grey-3};
158158
--status-adjustment: #{$color-grey-1};
159159
--status-danger: #{$color-red-1};
160+
--status-danger-transparent: #{$alpha-color-red-1};
160161
--status-success: #{$color-green-1};
161162
--status-warning: #{$color-yellow};
162163
--status-warning-transparent: #{$alpha-color-yellow-1};
163164
--status-transfer: #{$color-orange};
164165
--status-info: #{$color-blue};
166+
--status-info-transparent: #{$alpha-color-blue-1};
165167
--status-colored-background: #{$color-white};
166168
--status-alert-background: #{$color-yellow-3};
167169
// Dashboard

0 commit comments

Comments
 (0)