Merge pull request ota42y#154 from sasamuku/add_unique_items_validator

Support for uniqueItems in array

Author: ota42y

lib/openapi_parser/errors.rb

@@ -272,4 +272,15 @@ def message
       "#{@reference} #{@value.inspect} contains fewer than min items"
     end
   end
+
+  class NotUniqueItems < OpenAPIError
+    def initialize(value, reference)
+      super(reference)
+      @value = value
+    end
+
+    def message
+      "#{@reference} #{@value.inspect} contains duplicate items"
+    end
+  end
 end

lib/openapi_parser/schema_validator/array_validator.rb

@@ -8,6 +8,9 @@ def coerce_and_validate(value, schema, **_keyword_args)
       value, err = validate_max_min_items(value, schema)
       return [nil, err] if err
 
+      value, err = validate_unique_items(value, schema)
+      return [nil, err] if err
+
       # array type have an schema in items property
       items_schema = schema.items
       coerced_values = value.map do |v|
@@ -28,5 +31,11 @@ def validate_max_min_items(value, schema)
 
       [value, nil]
     end
+
+    def validate_unique_items(value, schema)
+      return [nil, OpenAPIParser::NotUniqueItems.new(value, schema.object_reference)] if schema.uniqueItems && value.length != value.uniq.length
+
+      [value, nil]
+    end
   end
 end

spec/openapi_parser/schema_validator/array_validator_spec.rb

@@ -19,7 +19,8 @@
           type: 'array',
           items: { 'type': 'integer' },
           maxItems: 2,
-          minItems: 1
+          minItems: 1,
+          uniqueItems: true
         },
       }
     end
@@ -53,6 +54,18 @@
           end
         end
       end
+
+      context 'unique items breached' do
+        let(:invalid_array) { [1, 1] }
+        let(:params) { { 'ids' => invalid_array } }
+
+        it do
+          expect { subject }.to raise_error do |e|
+            expect(e).to be_kind_of(OpenAPIParser::NotUniqueItems)
+            expect(e.message).to end_with("#{invalid_array} contains duplicate items")
+          end
+        end
+      end
     end
   end
 end