From 712895ac0ebae9023f2016974ca8b3612eedc535 Mon Sep 17 00:00:00 2001
From: Marian Rusnak <4215517+marian-r@users.noreply.github.com>
Date: Wed, 28 Aug 2024 17:06:06 -0400
Subject: [PATCH] =?UTF-8?q?=F0=9F=9A=AE=20remove=20yahoo=20ad=20component?=
=?UTF-8?q?=20as=20it=20is=20no=20longer=20in=20use=20nor=20working=20(#40?=
=?UTF-8?q?011)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* remove yahoo ad component as it is no longer in use nor working
* fix: removed missed yahoo.js file
* fix: cleanup all references to yahoo ad component
---
3p/integration.js | 2 -
3p/vendors/yahoo.js | 12 -----
ads/_config.js | 5 --
ads/vendors/yahoo.js | 17 ------
ads/vendors/yahoo.md | 64 -----------------------
examples/amp-ad/ads.amp.esm.html | 9 ----
examples/amp-ad/ads.amp.html | 6 ---
extensions/amp-ad/amp-ad.md | 1 -
validator/testdata/feature_tests/ads.html | 9 ----
validator/testdata/feature_tests/ads.out | 11 +---
10 files changed, 1 insertion(+), 135 deletions(-)
delete mode 100644 3p/vendors/yahoo.js
delete mode 100644 ads/vendors/yahoo.js
delete mode 100644 ads/vendors/yahoo.md
diff --git a/3p/integration.js b/3p/integration.js
index cbcf7d9f14e0..14dcc4d90bc4 100644
--- a/3p/integration.js
+++ b/3p/integration.js
@@ -287,7 +287,6 @@ import {wisteria} from '#ads/vendors/wisteria';
import {wpmedia} from '#ads/vendors/wpmedia';
import {wunderkind} from '#ads/vendors/wunderkind';
import {xlift} from '#ads/vendors/xlift';
-import {yahoo} from '#ads/vendors/yahoo';
import {yahoofedads} from '#ads/vendors/yahoofedads';
import {yahoojp} from '#ads/vendors/yahoojp';
import {yahoonativeads} from '#ads/vendors/yahoonativeads';
@@ -583,7 +582,6 @@ register('wisteria', wisteria);
register('wunderkind', wunderkind);
register('wpmedia', wpmedia);
register('xlift', xlift);
-register('yahoo', yahoo);
register('yahoofedads', yahoofedads);
register('yahoojp', yahoojp);
register('yahoonativeads', yahoonativeads);
diff --git a/3p/vendors/yahoo.js b/3p/vendors/yahoo.js
deleted file mode 100644
index 2d0f5475c193..000000000000
--- a/3p/vendors/yahoo.js
+++ /dev/null
@@ -1,12 +0,0 @@
-// src/polyfills.js must be the first import.
-import '#3p/polyfills';
-
-import {register} from '#3p/3p';
-import {draw3p, init} from '#3p/integration-lib';
-
-import {yahoo} from '#ads/vendors/yahoo';
-
-init(window);
-register('yahoo', yahoo);
-
-window.draw3p = draw3p;
diff --git a/ads/_config.js b/ads/_config.js
index 3ef0dda0665c..5fa24dc8703d 100755
--- a/ads/_config.js
+++ b/ads/_config.js
@@ -1487,11 +1487,6 @@ const adConfig = jsonConfiguration({
renderStartImplemented: true,
},
- 'yahoo': {
- prefetch: 'https://s.yimg.com/aaq/ampad/display.js',
- preconnect: 'https://us.adserver.yahoo.com',
- },
-
'yahoofedads': {
renderStartImplemented: true,
},
diff --git a/ads/vendors/yahoo.js b/ads/vendors/yahoo.js
deleted file mode 100644
index 3ef287d28235..000000000000
--- a/ads/vendors/yahoo.js
+++ /dev/null
@@ -1,17 +0,0 @@
-import {validateData, writeScript} from '#3p/3p';
-
-/**
- * @param {!Window} global
- * @param {!Object} data
- */
-export function yahoo(global, data) {
- if (data.sid) {
- validateData(data, ['sid', 'site', 'sa']);
- global.yadData = data;
- writeScript(global, 'https://s.yimg.com/aaq/ampad/display.js');
- } else if (data.config) {
- validateData(data, ['config']);
- global.jacData = data;
- writeScript(global, 'https://jac.yahoosandbox.com/amp/jac.js');
- }
-}
diff --git a/ads/vendors/yahoo.md b/ads/vendors/yahoo.md
deleted file mode 100644
index 97eea2222b91..000000000000
--- a/ads/vendors/yahoo.md
+++ /dev/null
@@ -1,64 +0,0 @@
-# yahoo
-
-## Display ad
-
-```html
-
-
-```
-
-```html
-
-
-```
-
-### Configuration
-
-For configuration details, please contact https://advertising.yahoo.com/contact.
-
-Supported parameters:
-
-- `height`
-- `width`
-- `data-sid`
-- `data-site`
-- `data-sa`
-- `data-config`
-- `data-stylesheet`
-
-### Required Parameters:
-
-`data-config` - Config for ad call JAC
-`data-sa` - Config for ad call DARLA
-
-### Optional parameters:
-
-`data-stylesheet` - stylesheet to use inside iframe
-
-### Configuration Details
-
-For JAC ads : Required
-"adServer":{"1AS":{region":"US"}},
-"positions":{"FB":{alias:"1111111"},"sizes":["300x250"]}},
-"site":{name:{"autoblogAMP"}},"spaceId":"111111"}
-
-Alias, Sizes, SiteName and spaceId should be replaced by correct values.
-NOTE: SiteName should be site name + "AMP"
-
-Optional
-"params":{"name":"value"}
diff --git a/examples/amp-ad/ads.amp.esm.html b/examples/amp-ad/ads.amp.esm.html
index 57097bf7b0e3..5125171a1c5c 100644
--- a/examples/amp-ad/ads.amp.esm.html
+++ b/examples/amp-ad/ads.amp.esm.html
@@ -290,7 +290,6 @@
-
@@ -2353,14 +2352,6 @@ Xlift native ad
data-mediaid="mamastar">
- Yahoo Display
-
-
-
Yahoo Native Ads
whopainfeed
-
@@ -1997,11 +1996,6 @@ Xlift native ad
- Yahoo Display
-
-
-
Yahoo Native-Display Ads Federation
weborama
-
@@ -1267,14 +1266,6 @@ Xlift native ad
data-mediaid="mamastar">
- Yahoo Display
-
-
-
YahooJP YDN
weborama
|
|
-|
|
|
|
@@ -1268,14 +1267,6 @@ PASS
| data-mediaid="mamastar">
|
|
-| Yahoo Display
-|
-|
-|
| YahooJP YDN
|
|
|
-|