-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [Extension AMP-AD] Implement feature to create a data vars slot id by unit when data-slot is entered #36160
✨ [Extension AMP-AD] Implement feature to create a data vars slot id by unit when data-slot is entered #36160
Conversation
…ame from use id to index
Hi @lannka |
Hi @lannka , Did you get a look? Is there anything I need to do? |
@ampproject/wg-monetization |
Hi @powerivq I made the changes you pointed, and I tried to create a 'macro' in amp-analytics consuming that attribute, however, I couldn't find a way to make it work correctly Could you give me a clue about how could I create that macro? |
Edmilson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Batch closing inactive PRs. |
The feature on this PR is to be able to create a data vars slot id by unit when data-slot is entered
I believe this feature is important to know the quantity os ad unit types have in one page on analytics trigger
psc @gurodrigues